Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wizard automation: check for response on "info needed" issue & close #4294

Merged
merged 4 commits into from
Nov 6, 2024

Conversation

merelcht
Copy link
Member

@merelcht merelcht commented Nov 1, 2024

Description

Any ticket labelled with support: need more info will be closed automatically after 14 days if the author doesn't respond. The label is removed if the author does respond.

Development notes

Developer Certificate of Origin

We need all contributions to comply with the Developer Certificate of Origin (DCO). All commits must be signed off by including a Signed-off-by line in the commit message. See our wiki for guidance.

If your PR is blocked due to unsigned commits, then you must follow the instructions under "Rebase the branch" on the GitHub Checks page for your PR. This will retroactively add the sign-off to all unsigned commits and allow the DCO check to pass.

Checklist

  • Read the contributing guidelines
  • Signed off each commit with a Developer Certificate of Origin (DCO)
  • Opened this PR as a 'Draft Pull Request' if it is work-in-progress
  • Updated the documentation to reflect the code changes
  • Added a description of this change in the RELEASE.md file
  • Added tests to cover my changes
  • Checked if this change will affect Kedro-Viz, and if so, communicated that with the Viz team

@rashidakanchwala
Copy link
Contributor

I am confused if we should close them or not? Can we not automate the closing part, as I feel it requires some manual intervention.

@merelcht
Copy link
Member Author

merelcht commented Nov 4, 2024

I am confused if we should close them or not? Can we not automate the closing part, as I feel it requires some manual intervention.

This GH action will close the ticket automatically if there's not response from the author after 14 days.

@rashidakanchwala
Copy link
Contributor

That makes sense. What I meant was that I feel undecided about automatically closing the issue in 14 days. It’s not uncommon for Viz-related community issues to remain open longer, often requiring multiple follow-ups to get user input. However, if you and @astrojuanlu are happy with the automatic 14-day closure, I’m ok with it too.

@merelcht
Copy link
Member Author

merelcht commented Nov 4, 2024

That makes sense. What I meant was that I feel undecided about automatically closing the issue in 14 days. It’s not uncommon for Viz-related community issues to remain open longer, often requiring multiple follow-ups to get user input. However, if you and @astrojuanlu are happy with the automatic 14-day closure, I’m ok with it too.

We can definitely make it longer! Or set a different limit for each repo. We'll have to add each action to the repos separately anyway.

@merelcht merelcht marked this pull request as ready for review November 5, 2024 08:42
merelcht and others added 2 commits November 6, 2024 10:39
Signed-off-by: Merel Theisen <[email protected]>
@merelcht merelcht enabled auto-merge (squash) November 6, 2024 12:03
@merelcht merelcht merged commit 826021d into main Nov 6, 2024
28 checks passed
@merelcht merelcht deleted the wizard-action-for-info-needed-label branch November 6, 2024 12:19
Copy link
Member

@astrojuanlu astrojuanlu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can always reopen if more information is provided, so I think 14 days is OK 👍🏼

@astrojuanlu
Copy link
Member

On second thought, wondering if 14 days might be too aggressive and we could bump it to 28.

@merelcht
Copy link
Member Author

merelcht commented Nov 7, 2024

Of course, I'll do that now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants