-
Notifications
You must be signed in to change notification settings - Fork 913
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Trufflehog version with pre-commit #4062
Comments
The issue here is that in order to run it locally with pre-commit we still need the package to be installed for entry https://github.com/trufflesecurity/trufflehog?tab=readme-ov-file#pre-commit-hook. Otherwise, we can run it only via For CI, we can use GitHub Action: https://github.com/trufflesecurity/trufflehog?tab=readme-ov-file#octocat-trufflehog-github-action, but the most value comes from local runs to prevent committing credentials. So we can use the maintained version from the repo at the CI but not locally. We can still make it a pre-commit hook with the current |
After a discussion with the team, it was decided to replace Considered alternatives for
|
Moved in back to |
Context
We have been using Trufflehog for scanning security issue with the code base. They stopped update the Python version years ago but maintain a pre-commit hook that can be used.
Description
Replace the dependency with pre-commit hook instead.
Yes, let's replace it!
Originally posted by @merelcht in #4005 (comment)
The text was updated successfully, but these errors were encountered: