Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs rendering a bit weird when click on header. #3459

Closed
noklam opened this issue Dec 21, 2023 · 3 comments
Closed

Docs rendering a bit weird when click on header. #3459

noklam opened this issue Dec 21, 2023 · 3 comments
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation

Comments

@noklam
Copy link
Contributor

noklam commented Dec 21, 2023

Description

https://docs.kedro.org/en/stable/get_started/kedro_concepts.html#src
image

https://docs.kedro.org/en/stable/get_started/kedro_concepts.html
Without the #src it renders normally.

Reproduce:

  1. Search src, click first result

Context

Is this intended or should it be a highlight instead? I would expect this behavior if I click it actively, but I get into this page via the search bar so I thought something is not rendered properly.

@stichbury
Copy link
Contributor

This seems to be a bug with the CSS -- I've spotted it this week but wasn't sure how to reproduce it and didn't prioritise it. I noticed if you go to any page e.g. https://docs.kedro.org/en/stable/hooks/common_use_cases.html it looks fine but if you click on a subheading link on that page e.g. https://docs.kedro.org/en/stable/hooks/common_use_cases.html#use-hooks-to-load-external-credentials you see that large whitespace above the header.

It's something for our webdev superstars to look into, so I'll put this in the Kedro Viz project for their attention...as it impacts their docs as well as Framework.

@stichbury stichbury added the Component: Documentation 📄 Issue/PR for markdown and API documentation label Dec 21, 2023
@rashidakanchwala
Copy link
Contributor

rashidakanchwala commented Nov 6, 2024

I spent some time attempting to fix this issue. Removing the extra spacing itself is straightforward, but after doing so, the anchors don’t scroll correctly to the intended sections. The headings are often missed due to an offset issue. I explored other solutions besides removing whitespace, including looking at how RTD and fsspec docs handle this, which seems to involve JS. I also tried a JS approach, but it didn’t resolve the problem.

I’ve gone beyond the timebox I set for this ticket, so @astrojuanlu , we can either revisit this in a future sprint or close it, given we are thinking of moving away from RTD.

Image

@astrojuanlu
Copy link
Member

Thanks @rashidakanchwala and good call on time boxing this. I'm okay closing this as "won't fix" although that means prioritising #4257 in the medium term.

@rashidakanchwala rashidakanchwala closed this as not planned Won't fix, can't repro, duplicate, stale Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation 📄 Issue/PR for markdown and API documentation
Projects
None yet
Development

No branches or pull requests

4 participants