From 9bfee0ed8e4d5814d761e28d163371128ca600cf Mon Sep 17 00:00:00 2001 From: Sajid Alam Date: Wed, 25 Sep 2024 13:59:33 +0100 Subject: [PATCH 01/13] Update CONTRIBUTING.md Signed-off-by: Sajid Alam --- CONTRIBUTING.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 9886fdf58b..eb3458d2c9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -139,6 +139,11 @@ Now you're ready to begin development. Start the development server: npm start ``` +> _*Note*_: If you face any issues running this, we recommend installing Node.js v18: +> +> 1. Delete `package-lock.json` and `node_modules`. +> 2. Run `npm install` to reinstall dependencies. + This will serve the app at [localhost:4141](http://localhost:4141/), and watch files in `/src` for changes. It will also update the `/lib` directory, which contains a Babel-compiled copy of the source. This directory is exported to `npm`, and is used when importing as a React component into another application. It is updated automatically when you save in case you need to test/debug it locally (e.g. with `npm link`). You can also update it manually, by running ```bash From e614c20013555056b6ad8c49751f1b25fb3d67d5 Mon Sep 17 00:00:00 2001 From: Sajid Alam Date: Mon, 30 Sep 2024 10:36:12 +0100 Subject: [PATCH 02/13] add suppressions for too many args Signed-off-by: Sajid Alam --- package/kedro_viz/data_access/managers.py | 2 +- package/kedro_viz/integrations/kedro/data_loader.py | 2 +- package/kedro_viz/launchers/cli/run.py | 2 +- package/kedro_viz/launchers/cli/utils.py | 2 +- package/kedro_viz/models/flowchart.py | 4 ++-- package/kedro_viz/server.py | 4 ++-- 6 files changed, 8 insertions(+), 8 deletions(-) diff --git a/package/kedro_viz/data_access/managers.py b/package/kedro_viz/data_access/managers.py index 9801c86cb7..e543672ef1 100644 --- a/package/kedro_viz/data_access/managers.py +++ b/package/kedro_viz/data_access/managers.py @@ -237,7 +237,7 @@ def add_node_input( task_node: TaskNode, modular_pipelines_repo_obj: ModularPipelinesRepository, is_free_input: bool = False, - ) -> Union[DataNode, TranscodedDataNode, ParametersNode]: + ) -> Union[DataNode, TranscodedDataNode, ParametersNode]: # pylint: disable=too-many-positional-arguments """Add a Kedro node's input as a DataNode, TranscodedDataNode or ParametersNode to the NodesRepository for a given registered pipeline ID. diff --git a/package/kedro_viz/integrations/kedro/data_loader.py b/package/kedro_viz/integrations/kedro/data_loader.py index 2955d73b29..7961c73e63 100644 --- a/package/kedro_viz/integrations/kedro/data_loader.py +++ b/package/kedro_viz/integrations/kedro/data_loader.py @@ -115,7 +115,7 @@ def load_data( package_name: Optional[str] = None, extra_params: Optional[Dict[str, Any]] = None, is_lite: bool = False, -) -> Tuple[DataCatalog, Dict[str, Pipeline], BaseSessionStore, Dict]: +) -> Tuple[DataCatalog, Dict[str, Pipeline], BaseSessionStore, Dict]: # pylint: disable=too-many-positional-arguments """Load data from a Kedro project. Args: project_path: the path where the Kedro project is located. diff --git a/package/kedro_viz/launchers/cli/run.py b/package/kedro_viz/launchers/cli/run.py index 9988214261..97c9ab3dbc 100644 --- a/package/kedro_viz/launchers/cli/run.py +++ b/package/kedro_viz/launchers/cli/run.py @@ -83,7 +83,7 @@ is_flag=True, help="An experimental flag to open Kedro-Viz without Kedro project dependencies", ) -# pylint: disable=import-outside-toplevel, too-many-locals +# pylint: disable=import-outside-toplevel, too-many-locals, too-many-positional-arguments def run( host, port, diff --git a/package/kedro_viz/launchers/cli/utils.py b/package/kedro_viz/launchers/cli/utils.py index eb4efdfbc9..f5cbbfc919 100644 --- a/package/kedro_viz/launchers/cli/utils.py +++ b/package/kedro_viz/launchers/cli/utils.py @@ -123,7 +123,7 @@ def _load_and_deploy_viz( package_name, process_completed, exception_queue, -): +): # pylint: disable=too-many-positional-arguments """Loads Kedro Project data, creates a deployer and deploys to a platform""" try: from kedro_viz.integrations.deployment.deployer_factory import DeployerFactory diff --git a/package/kedro_viz/models/flowchart.py b/package/kedro_viz/models/flowchart.py index e8e81cfb61..273baef199 100644 --- a/package/kedro_viz/models/flowchart.py +++ b/package/kedro_viz/models/flowchart.py @@ -174,7 +174,7 @@ def create_data_node( stats: Optional[Dict], modular_pipelines: Optional[Set[str]], is_free_input: bool = False, - ) -> Union["DataNode", "TranscodedDataNode"]: + ) -> Union["DataNode", "TranscodedDataNode"]: # pylint: disable=too-many-positional-arguments """Create a graph node of type data for a given Kedro Dataset instance. Args: dataset_id: A hashed id for the dataset node @@ -224,7 +224,7 @@ def create_parameters_node( tags: Set[str], parameters: AbstractDataset, modular_pipelines: Optional[Set[str]], - ) -> "ParametersNode": + ) -> "ParametersNode": # pylint: disable=too-many-positional-arguments """Create a graph node of type parameters for a given Kedro parameters dataset instance. Args: dataset_id: A hashed id for the parameters node diff --git a/package/kedro_viz/server.py b/package/kedro_viz/server.py index 76026ddbbf..7387d5a915 100644 --- a/package/kedro_viz/server.py +++ b/package/kedro_viz/server.py @@ -52,7 +52,7 @@ def load_and_populate_data( pipeline_name: Optional[str] = None, extra_params: Optional[Dict[str, Any]] = None, is_lite: bool = False, -): +): # pylint: disable=too-many-positional-arguments """Loads underlying Kedro project data and populates Kedro Viz Repositories""" # Loads data from underlying Kedro Project @@ -84,7 +84,7 @@ def run_server( package_name: Optional[str] = None, extra_params: Optional[Dict[str, Any]] = None, is_lite: bool = False, -): # pylint: disable=redefined-outer-name +): # pylint: disable=redefined-outer-name, too-many-positional-arguments """Run a uvicorn server with a FastAPI app that either launches API response data from a file or from reading data from a real Kedro project. From 59d01491f0fdbb20276bacc081f1ec3034f58190 Mon Sep 17 00:00:00 2001 From: Sajid Alam Date: Mon, 30 Sep 2024 10:41:39 +0100 Subject: [PATCH 03/13] lint Signed-off-by: Sajid Alam --- package/kedro_viz/data_access/managers.py | 4 +++- package/kedro_viz/integrations/kedro/data_loader.py | 4 +++- package/kedro_viz/models/flowchart.py | 4 +++- 3 files changed, 9 insertions(+), 3 deletions(-) diff --git a/package/kedro_viz/data_access/managers.py b/package/kedro_viz/data_access/managers.py index e543672ef1..a52e349a37 100644 --- a/package/kedro_viz/data_access/managers.py +++ b/package/kedro_viz/data_access/managers.py @@ -237,7 +237,9 @@ def add_node_input( task_node: TaskNode, modular_pipelines_repo_obj: ModularPipelinesRepository, is_free_input: bool = False, - ) -> Union[DataNode, TranscodedDataNode, ParametersNode]: # pylint: disable=too-many-positional-arguments + ) -> Union[ + DataNode, TranscodedDataNode, ParametersNode + ]: # pylint: disable=too-many-positional-arguments """Add a Kedro node's input as a DataNode, TranscodedDataNode or ParametersNode to the NodesRepository for a given registered pipeline ID. diff --git a/package/kedro_viz/integrations/kedro/data_loader.py b/package/kedro_viz/integrations/kedro/data_loader.py index 7961c73e63..f467f7626b 100644 --- a/package/kedro_viz/integrations/kedro/data_loader.py +++ b/package/kedro_viz/integrations/kedro/data_loader.py @@ -115,7 +115,9 @@ def load_data( package_name: Optional[str] = None, extra_params: Optional[Dict[str, Any]] = None, is_lite: bool = False, -) -> Tuple[DataCatalog, Dict[str, Pipeline], BaseSessionStore, Dict]: # pylint: disable=too-many-positional-arguments +) -> Tuple[ + DataCatalog, Dict[str, Pipeline], BaseSessionStore, Dict +]: # pylint: disable=too-many-positional-arguments """Load data from a Kedro project. Args: project_path: the path where the Kedro project is located. diff --git a/package/kedro_viz/models/flowchart.py b/package/kedro_viz/models/flowchart.py index 273baef199..4aa813554f 100644 --- a/package/kedro_viz/models/flowchart.py +++ b/package/kedro_viz/models/flowchart.py @@ -174,7 +174,9 @@ def create_data_node( stats: Optional[Dict], modular_pipelines: Optional[Set[str]], is_free_input: bool = False, - ) -> Union["DataNode", "TranscodedDataNode"]: # pylint: disable=too-many-positional-arguments + ) -> Union[ + "DataNode", "TranscodedDataNode" + ]: # pylint: disable=too-many-positional-arguments """Create a graph node of type data for a given Kedro Dataset instance. Args: dataset_id: A hashed id for the dataset node From a09b6b6446d1ffabf44ca4bf0ded5c072ee9f7e7 Mon Sep 17 00:00:00 2001 From: Sajid Alam Date: Mon, 30 Sep 2024 10:53:13 +0100 Subject: [PATCH 04/13] remove useless suppressions Signed-off-by: Sajid Alam --- package/kedro_viz/data_access/managers.py | 5 ++--- package/kedro_viz/integrations/kedro/data_loader.py | 5 ++--- package/kedro_viz/models/flowchart.py | 8 ++++---- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/package/kedro_viz/data_access/managers.py b/package/kedro_viz/data_access/managers.py index a52e349a37..40e00ebe55 100644 --- a/package/kedro_viz/data_access/managers.py +++ b/package/kedro_viz/data_access/managers.py @@ -230,6 +230,7 @@ def add_node( self.tags.add_tags(task_node.tags) return task_node + # pylint: disable=too-many-positional-arguments def add_node_input( self, registered_pipeline_id: str, @@ -237,9 +238,7 @@ def add_node_input( task_node: TaskNode, modular_pipelines_repo_obj: ModularPipelinesRepository, is_free_input: bool = False, - ) -> Union[ - DataNode, TranscodedDataNode, ParametersNode - ]: # pylint: disable=too-many-positional-arguments + ) -> Union[DataNode, TranscodedDataNode, ParametersNode]: """Add a Kedro node's input as a DataNode, TranscodedDataNode or ParametersNode to the NodesRepository for a given registered pipeline ID. diff --git a/package/kedro_viz/integrations/kedro/data_loader.py b/package/kedro_viz/integrations/kedro/data_loader.py index f467f7626b..aabc5b73a5 100644 --- a/package/kedro_viz/integrations/kedro/data_loader.py +++ b/package/kedro_viz/integrations/kedro/data_loader.py @@ -108,6 +108,7 @@ def _load_data_helper( return catalog, pipelines_dict, session_store, stats_dict +# pylint: disable=too-many-positional-arguments def load_data( project_path: Path, env: Optional[str] = None, @@ -115,9 +116,7 @@ def load_data( package_name: Optional[str] = None, extra_params: Optional[Dict[str, Any]] = None, is_lite: bool = False, -) -> Tuple[ - DataCatalog, Dict[str, Pipeline], BaseSessionStore, Dict -]: # pylint: disable=too-many-positional-arguments +) -> Tuple[DataCatalog, Dict[str, Pipeline], BaseSessionStore, Dict]: """Load data from a Kedro project. Args: project_path: the path where the Kedro project is located. diff --git a/package/kedro_viz/models/flowchart.py b/package/kedro_viz/models/flowchart.py index 4aa813554f..633e1d9986 100644 --- a/package/kedro_viz/models/flowchart.py +++ b/package/kedro_viz/models/flowchart.py @@ -163,6 +163,7 @@ def create_task_node( modular_pipelines=modular_pipelines, ) + # pylint: disable=too-many-positional-arguments @classmethod def create_data_node( cls, @@ -174,9 +175,7 @@ def create_data_node( stats: Optional[Dict], modular_pipelines: Optional[Set[str]], is_free_input: bool = False, - ) -> Union[ - "DataNode", "TranscodedDataNode" - ]: # pylint: disable=too-many-positional-arguments + ) -> Union["DataNode", "TranscodedDataNode"]: """Create a graph node of type data for a given Kedro Dataset instance. Args: dataset_id: A hashed id for the dataset node @@ -217,6 +216,7 @@ def create_data_node( modular_pipelines=modular_pipelines, ) + # pylint: disable=too-many-positional-arguments @classmethod def create_parameters_node( cls, @@ -226,7 +226,7 @@ def create_parameters_node( tags: Set[str], parameters: AbstractDataset, modular_pipelines: Optional[Set[str]], - ) -> "ParametersNode": # pylint: disable=too-many-positional-arguments + ) -> "ParametersNode": """Create a graph node of type parameters for a given Kedro parameters dataset instance. Args: dataset_id: A hashed id for the parameters node From e99abfab66d50d30210d2caef5b86b862efbf0d8 Mon Sep 17 00:00:00 2001 From: Sajid Alam Date: Mon, 30 Sep 2024 11:05:00 +0100 Subject: [PATCH 05/13] Update apps.py Signed-off-by: Sajid Alam --- package/kedro_viz/api/apps.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/kedro_viz/api/apps.py b/package/kedro_viz/api/apps.py index 7200ad4ab7..aef4d44715 100644 --- a/package/kedro_viz/api/apps.py +++ b/package/kedro_viz/api/apps.py @@ -42,7 +42,7 @@ def _create_base_api_app() -> FastAPI: @app.middleware("http") async def set_secure_headers(request, call_next): response = await call_next(request) - secure_headers.framework.fastapi(response) + secure_headers.framework.fastapi(response) # pylint: disable=no-member return response return app From c3e02214969e10deeb07b1fdcb4b792eaa4a6bee Mon Sep 17 00:00:00 2001 From: Sajid Alam Date: Mon, 30 Sep 2024 11:13:25 +0100 Subject: [PATCH 06/13] Update Makefile Signed-off-by: Sajid Alam --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 9536ca63cc..f2b5157949 100644 --- a/Makefile +++ b/Makefile @@ -36,7 +36,7 @@ format-check: lint-check: pylint --rcfile=package/.pylintrc -j 0 package/kedro_viz - pylint --rcfile=package/.pylintrc -j 0 --disable=protected-access,missing-docstring,redefined-outer-name,invalid-name,too-few-public-methods,no-member,unused-argument,duplicate-code,abstract-class-instantiated package/tests + pylint --rcfile=package/.pylintrc -j 0 --disable=protected-access,missing-docstring,redefined-outer-name,invalid-name,too-few-public-methods,no-member,unused-argument,duplicate-code,abstract-class-instantiated,too-many-positional-arguments package/tests pylint --rcfile=package/.pylintrc -j 0 --disable=missing-docstring,no-name-in-module,unused-argument package/features flake8 --config=package/.flake8 package mypy --config-file=package/mypy.ini package/kedro_viz package/features From 086294b5c00eade88e2777165b09fc7768c87f44 Mon Sep 17 00:00:00 2001 From: Sajid Alam Date: Mon, 30 Sep 2024 11:22:36 +0100 Subject: [PATCH 07/13] fix Signed-off-by: Sajid Alam --- package/kedro_viz/data_access/repositories/catalog.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package/kedro_viz/data_access/repositories/catalog.py b/package/kedro_viz/data_access/repositories/catalog.py index 50fc5dce04..a7d568ca8a 100644 --- a/package/kedro_viz/data_access/repositories/catalog.py +++ b/package/kedro_viz/data_access/repositories/catalog.py @@ -131,8 +131,7 @@ def get_dataset(self, dataset_name: str) -> Optional["AbstractDataset"]: else: # pragma: no cover dataset_obj = self._catalog._get_dataset(dataset_name) except DatasetNotFoundError: - # pylint: disable=abstract-class-instantiated - dataset_obj = MemoryDataset() # type: ignore[abstract] + dataset_obj = MemoryDataset() # pylint: disable=abstract-class-instantiated return dataset_obj From bb6dc1c97d253ceb237c88fe641a7876f4959a1c Mon Sep 17 00:00:00 2001 From: Sajid Alam Date: Mon, 30 Sep 2024 11:58:20 +0100 Subject: [PATCH 08/13] Update catalog.py Signed-off-by: Sajid Alam --- package/kedro_viz/data_access/repositories/catalog.py | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/package/kedro_viz/data_access/repositories/catalog.py b/package/kedro_viz/data_access/repositories/catalog.py index a7d568ca8a..50fc5dce04 100644 --- a/package/kedro_viz/data_access/repositories/catalog.py +++ b/package/kedro_viz/data_access/repositories/catalog.py @@ -131,7 +131,8 @@ def get_dataset(self, dataset_name: str) -> Optional["AbstractDataset"]: else: # pragma: no cover dataset_obj = self._catalog._get_dataset(dataset_name) except DatasetNotFoundError: - dataset_obj = MemoryDataset() # pylint: disable=abstract-class-instantiated + # pylint: disable=abstract-class-instantiated + dataset_obj = MemoryDataset() # type: ignore[abstract] return dataset_obj From 57da37a0d47ab90051f7185ef35cdfd419a602a0 Mon Sep 17 00:00:00 2001 From: Sajid Alam Date: Mon, 30 Sep 2024 12:06:50 +0100 Subject: [PATCH 09/13] Update catalog.py Signed-off-by: Sajid Alam --- package/kedro_viz/data_access/repositories/catalog.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/package/kedro_viz/data_access/repositories/catalog.py b/package/kedro_viz/data_access/repositories/catalog.py index 50fc5dce04..38f2171d1f 100644 --- a/package/kedro_viz/data_access/repositories/catalog.py +++ b/package/kedro_viz/data_access/repositories/catalog.py @@ -132,7 +132,7 @@ def get_dataset(self, dataset_name: str) -> Optional["AbstractDataset"]: dataset_obj = self._catalog._get_dataset(dataset_name) except DatasetNotFoundError: # pylint: disable=abstract-class-instantiated - dataset_obj = MemoryDataset() # type: ignore[abstract] + dataset_obj = MemoryDataset() # type: ignore return dataset_obj From 87aaad811cd50f1c99947510c4848b83180b0bd6 Mon Sep 17 00:00:00 2001 From: Sajid Alam Date: Mon, 30 Sep 2024 12:12:59 +0100 Subject: [PATCH 10/13] Update catalog.py Signed-off-by: Sajid Alam --- package/kedro_viz/data_access/repositories/catalog.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/package/kedro_viz/data_access/repositories/catalog.py b/package/kedro_viz/data_access/repositories/catalog.py index 38f2171d1f..a7d568ca8a 100644 --- a/package/kedro_viz/data_access/repositories/catalog.py +++ b/package/kedro_viz/data_access/repositories/catalog.py @@ -131,8 +131,7 @@ def get_dataset(self, dataset_name: str) -> Optional["AbstractDataset"]: else: # pragma: no cover dataset_obj = self._catalog._get_dataset(dataset_name) except DatasetNotFoundError: - # pylint: disable=abstract-class-instantiated - dataset_obj = MemoryDataset() # type: ignore + dataset_obj = MemoryDataset() # pylint: disable=abstract-class-instantiated return dataset_obj From 940bdc83d3cc14907ed045de2086ba22c460493f Mon Sep 17 00:00:00 2001 From: Sajid Alam Date: Mon, 30 Sep 2024 12:21:16 +0100 Subject: [PATCH 11/13] revert and change max positional args Signed-off-by: Sajid Alam --- package/.pylintrc | 2 +- package/kedro_viz/data_access/managers.py | 1 - package/kedro_viz/integrations/kedro/data_loader.py | 1 - package/kedro_viz/launchers/cli/run.py | 2 +- package/kedro_viz/launchers/cli/utils.py | 2 +- package/kedro_viz/models/flowchart.py | 2 -- package/kedro_viz/server.py | 4 ++-- 7 files changed, 5 insertions(+), 9 deletions(-) diff --git a/package/.pylintrc b/package/.pylintrc index a14d86bd4d..cab73b2a0c 100644 --- a/package/.pylintrc +++ b/package/.pylintrc @@ -321,7 +321,7 @@ valid-metaclass-classmethod-first-arg=mcs [DESIGN] # Maximum number of arguments for function / method -max-args=5 +max-args=12 # Maximum number of attributes for a class (see R0902). max-attributes=7 diff --git a/package/kedro_viz/data_access/managers.py b/package/kedro_viz/data_access/managers.py index 40e00ebe55..9801c86cb7 100644 --- a/package/kedro_viz/data_access/managers.py +++ b/package/kedro_viz/data_access/managers.py @@ -230,7 +230,6 @@ def add_node( self.tags.add_tags(task_node.tags) return task_node - # pylint: disable=too-many-positional-arguments def add_node_input( self, registered_pipeline_id: str, diff --git a/package/kedro_viz/integrations/kedro/data_loader.py b/package/kedro_viz/integrations/kedro/data_loader.py index aabc5b73a5..2955d73b29 100644 --- a/package/kedro_viz/integrations/kedro/data_loader.py +++ b/package/kedro_viz/integrations/kedro/data_loader.py @@ -108,7 +108,6 @@ def _load_data_helper( return catalog, pipelines_dict, session_store, stats_dict -# pylint: disable=too-many-positional-arguments def load_data( project_path: Path, env: Optional[str] = None, diff --git a/package/kedro_viz/launchers/cli/run.py b/package/kedro_viz/launchers/cli/run.py index 97c9ab3dbc..9988214261 100644 --- a/package/kedro_viz/launchers/cli/run.py +++ b/package/kedro_viz/launchers/cli/run.py @@ -83,7 +83,7 @@ is_flag=True, help="An experimental flag to open Kedro-Viz without Kedro project dependencies", ) -# pylint: disable=import-outside-toplevel, too-many-locals, too-many-positional-arguments +# pylint: disable=import-outside-toplevel, too-many-locals def run( host, port, diff --git a/package/kedro_viz/launchers/cli/utils.py b/package/kedro_viz/launchers/cli/utils.py index f5cbbfc919..eb4efdfbc9 100644 --- a/package/kedro_viz/launchers/cli/utils.py +++ b/package/kedro_viz/launchers/cli/utils.py @@ -123,7 +123,7 @@ def _load_and_deploy_viz( package_name, process_completed, exception_queue, -): # pylint: disable=too-many-positional-arguments +): """Loads Kedro Project data, creates a deployer and deploys to a platform""" try: from kedro_viz.integrations.deployment.deployer_factory import DeployerFactory diff --git a/package/kedro_viz/models/flowchart.py b/package/kedro_viz/models/flowchart.py index 633e1d9986..e8e81cfb61 100644 --- a/package/kedro_viz/models/flowchart.py +++ b/package/kedro_viz/models/flowchart.py @@ -163,7 +163,6 @@ def create_task_node( modular_pipelines=modular_pipelines, ) - # pylint: disable=too-many-positional-arguments @classmethod def create_data_node( cls, @@ -216,7 +215,6 @@ def create_data_node( modular_pipelines=modular_pipelines, ) - # pylint: disable=too-many-positional-arguments @classmethod def create_parameters_node( cls, diff --git a/package/kedro_viz/server.py b/package/kedro_viz/server.py index 7387d5a915..76026ddbbf 100644 --- a/package/kedro_viz/server.py +++ b/package/kedro_viz/server.py @@ -52,7 +52,7 @@ def load_and_populate_data( pipeline_name: Optional[str] = None, extra_params: Optional[Dict[str, Any]] = None, is_lite: bool = False, -): # pylint: disable=too-many-positional-arguments +): """Loads underlying Kedro project data and populates Kedro Viz Repositories""" # Loads data from underlying Kedro Project @@ -84,7 +84,7 @@ def run_server( package_name: Optional[str] = None, extra_params: Optional[Dict[str, Any]] = None, is_lite: bool = False, -): # pylint: disable=redefined-outer-name, too-many-positional-arguments +): # pylint: disable=redefined-outer-name """Run a uvicorn server with a FastAPI app that either launches API response data from a file or from reading data from a real Kedro project. From 63896bbdd69ec4345a9d64c09ebcdc5190476e69 Mon Sep 17 00:00:00 2001 From: Sajid Alam Date: Mon, 30 Sep 2024 12:30:26 +0100 Subject: [PATCH 12/13] disable too-many-positional-arguments Signed-off-by: Sajid Alam --- package/.pylintrc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/package/.pylintrc b/package/.pylintrc index cab73b2a0c..e8ae443c08 100644 --- a/package/.pylintrc +++ b/package/.pylintrc @@ -50,7 +50,7 @@ confidence= # --enable=similarities". If you want to run only the classes checker, but have # no Warning level messages displayed, use"--disable=all --enable=classes # --disable=W" -disable=ungrouped-imports,attribute-defined-outside-init,too-many-arguments,duplicate-code,fixme +disable=ungrouped-imports,attribute-defined-outside-init,too-many-arguments,duplicate-code,too-many-positional-arguments,fixme # Enable the message, report, category or checker with the given id(s). You can # either give multiple identifier separated by comma (,) or put this option @@ -321,7 +321,7 @@ valid-metaclass-classmethod-first-arg=mcs [DESIGN] # Maximum number of arguments for function / method -max-args=12 +max-args=5 # Maximum number of attributes for a class (see R0902). max-attributes=7 From 596ebe37accc8d68f55e3025ba2b60ffc5efb1a9 Mon Sep 17 00:00:00 2001 From: Sajid Alam Date: Mon, 30 Sep 2024 12:43:17 +0100 Subject: [PATCH 13/13] Update Makefile Signed-off-by: Sajid Alam --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index f2b5157949..9536ca63cc 100644 --- a/Makefile +++ b/Makefile @@ -36,7 +36,7 @@ format-check: lint-check: pylint --rcfile=package/.pylintrc -j 0 package/kedro_viz - pylint --rcfile=package/.pylintrc -j 0 --disable=protected-access,missing-docstring,redefined-outer-name,invalid-name,too-few-public-methods,no-member,unused-argument,duplicate-code,abstract-class-instantiated,too-many-positional-arguments package/tests + pylint --rcfile=package/.pylintrc -j 0 --disable=protected-access,missing-docstring,redefined-outer-name,invalid-name,too-few-public-methods,no-member,unused-argument,duplicate-code,abstract-class-instantiated package/tests pylint --rcfile=package/.pylintrc -j 0 --disable=missing-docstring,no-name-in-module,unused-argument package/features flake8 --config=package/.flake8 package mypy --config-file=package/mypy.ini package/kedro_viz package/features