Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undefined Value for expandAllPipelines Flag after Removal from config.js #1883

Closed
SajidAlamQB opened this issue Apr 30, 2024 · 0 comments · Fixed by #1896
Closed

Undefined Value for expandAllPipelines Flag after Removal from config.js #1883

SajidAlamQB opened this issue Apr 30, 2024 · 0 comments · Fixed by #1896
Assignees
Labels
Issue: Bug Report Javascript Pull requests that update Javascript code

Comments

@SajidAlamQB
Copy link
Contributor

SajidAlamQB commented Apr 30, 2024

Description

See slack thread: https://kedro-org.slack.com/archives/C04EHA3K7C2/p1714426656093459

Following, #1858, the expandAllPipelines flag from config.js was removed which is causing an undefined value, as it is no longer has a default value. This flag was previously used to control the state of expanding all modular pipelines on the initial load of the application in the settings-modal.js.

The code within settings-modal.js uses the getFlagsState function to pull flag data, which included expandAllPipelines. The assumption was that removing it from config.js would suffice for this UI adjustment. However, this led to the flag being undefined elsewhere in the application.

We need to think about how the expandAllPipelines flag should be removed from just from the settings modal.

Suggestions:

  • We reintroduce the expandAllPipelines flag into config.js and change settings-modal to not include.
  • implement a new way to initialise this flag across viz, maybe outside of config.js?

Steps to Reproduce

Load the application and see that the flag's value is undefined.

Expected Result

expandAllPipelines should have a default value.

Actual Result

expandAllPipelines is undefined.

@rashidakanchwala rashidakanchwala moved this to Inbox in Kedro-Viz May 7, 2024
@ravi-kumar-pilla ravi-kumar-pilla self-assigned this May 8, 2024
@ravi-kumar-pilla ravi-kumar-pilla moved this from Inbox to Todo in Kedro-Viz May 8, 2024
@ravi-kumar-pilla ravi-kumar-pilla moved this from Todo to In Progress in Kedro-Viz May 8, 2024
@Huongg Huongg moved this from In Progress to In Review in Kedro-Viz May 9, 2024
@rashidakanchwala rashidakanchwala added the Javascript Pull requests that update Javascript code label May 13, 2024
@ravi-kumar-pilla ravi-kumar-pilla moved this from In Review to In Progress in Kedro-Viz May 13, 2024
@ravi-kumar-pilla ravi-kumar-pilla moved this from In Progress to In Review in Kedro-Viz May 15, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done in Kedro-Viz May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report Javascript Pull requests that update Javascript code
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants