Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flowchart view inconsistency with tag filters #1822

Closed
1 task done
ravi-kumar-pilla opened this issue Mar 26, 2024 · 1 comment
Closed
1 task done

Flowchart view inconsistency with tag filters #1822

ravi-kumar-pilla opened this issue Mar 26, 2024 · 1 comment
Assignees
Labels
Issue: Bug Report Python Pull requests that update Python code

Comments

@ravi-kumar-pilla
Copy link
Contributor

ravi-kumar-pilla commented Mar 26, 2024

Description

Incase of expandModularPipelines = false and the filtered nodes happened to be inside a modular pipeline, it should show the modular pipeline node (collapsed view) which seems to be missing on refresh.

#1799 (comment)

Context

When I use tag filtering and if I do not have modular pipelines expanded, on page refresh I am missing few nodes which do have the tags. This causes an incorrect DAG rendering. This may be due to the modular pipelines not inheriting the tags from the children nodes. The changes needs to be propagated from the backend.

Steps to Reproduce

Explained here

Expected Result

When I use tag filtering and if I do not have modular pipelines expanded, on page refresh I should see the collapsed view of the modular pipeline as I see when I do not hit refresh

Actual Result

When I use tag filtering and if I do not have modular pipelines expanded, on page refresh I am missing the entire modular pipeline which has nodes that have the tags.

Your Environment

Include as many relevant details as possible about the environment you experienced the bug in:

  • Web browser system and version: Chrome
  • Operating system and version: macOS
  • NodeJS version used (if relevant):
  • Kedro version used (if relevant):
  • Python version used (if relevant):

Checklist

  • Include labels so that we can categorise your issue
@ravi-kumar-pilla ravi-kumar-pilla added Issue: Bug Report Python Pull requests that update Python code labels Mar 26, 2024
@rashidakanchwala
Copy link
Contributor

@ravi-kumar-pilla to update this ticket with more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Issue: Bug Report Python Pull requests that update Python code
Projects
None yet
Development

No branches or pull requests

3 participants