-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve CI on Kedro-Viz #1805
Comments
@astrojuanlu , @ravi-kumar-pilla - I can't find the other ticket bur our CI takes very very long for each commit. I remember we had done improvements last time that got us from 30 min to 10 min, and now it's back to 30+ minutes. This really slows us down. Can we reprioritise this ticket. Maybe find dev time to work on it in December? , since there's no major feature work happening as a lot of us are on break. |
Looking at https://github.com/kedro-org/kedro-viz/actions/runs/11933469103, looks like
I agree @rashidakanchwala, let's tackle this ASAP! As early as right now if we have the resources. |
About lint, it takes 13 minutes just to install the dependencies and half a minute actually running the linter. It's important to note that linting and formatting does not need the runtime dependencies. In other words: you can Unit tests also spend 17 minutes just setting things up, half a minute running the tests. e2e spends 16 minutes just installing things. I think it's very clear that |
This issue will be addressed in two phases:
|
Additionally, in setup_tests, it would be ideal to avoid installing front-end dependencies unless running e2e tests. We could consider adding a condition similar to the example below to address this.
|
What's left to do here? Also is this connected with #1908 ? |
Both the tickets are on me :) ....
I can take these 2 tickets in the coming sprints once the notebook work is done. Thank you |
Description
Improve CI execution time for backend unit tests which should not rely on building the react application, rather depend only on backend functions.
Context
When we are running unit_tests on CircleCI, during build_backend we have the following steps -
The
setup
step has -Possible Implementation
Possible Alternatives
Checklist
The text was updated successfully, but these errors were encountered: