Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide show code buttom in kedro-viz #1703

Closed
1 task
jiohao opened this issue Jan 15, 2024 · 5 comments
Closed
1 task

hide show code buttom in kedro-viz #1703

jiohao opened this issue Jan 15, 2024 · 5 comments

Comments

@jiohao
Copy link

jiohao commented Jan 15, 2024

Description

We think that normal users do not need to see show code. So we want to create 2 vision viz for different role.

Context

Different roles are suitable for different scenarios. The button settings of viz can make the use more flexible.

Possible Implementation

(Optional) setting by yml

Possible Alternatives

Checklist

  • Include labels so that we can categorise your feature request
@rashidakanchwala rashidakanchwala moved this to Inbox in Kedro-Viz Jan 15, 2024
@jiohao jiohao changed the title <Title>hide show code buttom in kedro-viz hide show code buttom in kedro-viz Jan 15, 2024
@rashidakanchwala rashidakanchwala moved this from Inbox to Backlog in Kedro-Viz Jan 15, 2024
@astrojuanlu
Copy link
Member

Hi @jiohao, thanks a lot for opening this issue.

Note that doing this properly might require building an authentication & authorization layer on top of Kedro-Viz, which is no small feat. Therefore, if we ever get to this, it would take us some time to get there.

Just to set clear expectations 😄

@jiohao
Copy link
Author

jiohao commented Jan 18, 2024

In our case, we do authentication & authorization by ourself. We already have define role in different project and want to let different role(DS and Domain) to see suitable viz vision.So we need setting by yml or other method.

@NeroOkwa
Copy link
Contributor

@jiohao it would be great to get user feedback from you(your team) on your Kedro-Viz experience.

@rashidakanchwala
Copy link
Contributor

Closing this for now.

@rashidakanchwala rashidakanchwala closed this as not planned Won't fix, can't repro, duplicate, stale May 20, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Kedro-Viz May 20, 2024
@astrojuanlu
Copy link
Member

@jiohao We discussed about this and we prefer to take a broader look at how users would like to customise the Kedro Viz UI for debugging, collaboration and reporting. More details to follow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

4 participants