Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create SQL-based data node in demo-project #1583

Closed
MehdiNV opened this issue Oct 16, 2023 · 1 comment
Closed

Create SQL-based data node in demo-project #1583

MehdiNV opened this issue Oct 16, 2023 · 1 comment

Comments

@MehdiNV
Copy link
Contributor

MehdiNV commented Oct 16, 2023

Description

PR #1564 adds a 'preview' mechanism for (some) data nodes, allowing users to glimpse the origin of that data (e.g. this node was generated via SQL; what was that particular SQL code?).

This mechanism is only visible for data nodes w/ no files, and useful when you'd like to see the origin of a node who has no file.

There is no example of this though to show to users; aim of this PR is to add a dummy node so we can exhibit the new feature.

Context

We've added a new feature, but it's only visible if the users specifically use a SQLQueryDataset node. If they don't, they may not even understand that the feature exists.

Point is to add a SQLQueryDataset data node in demo-project, to showcase the feature.

Possible Implementation

A partial implementation can be in this commit - PR #1564 removed this change later on though to reduce scope (and ship out faster, as this change can just be a separate issue instead of one giant large PR).

To complete this implementation, you may need to setup a SQLAlchemy connection (otherwise pipelines may fail, as they expect SQLQueryDataset to be connected to a SQL database) or some mock dummy SQL DB (SQLite?).

@tynandebold
Copy link
Member

How much work would it be to add this to your PR? #1564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants