-
Notifications
You must be signed in to change notification settings - Fork 113
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend 'preview' functionality to PartitionedDatasets such as Plotly, Pandas Tables (CSV, Excel) #1319
Comments
Thanks a lot for this suggestion @robguilarr! Could you add a code snippet of how do you imagine your catalog entry and corresponding node functions to look like? |
Very relevant: kedro-org/kedro-plugins#529 and my comments on #783 (comment). @robguilarr how would you feel about doing this using a # catalog.yml
multiple_plots:
type: PartitionedDataset
filepath: data/plots/
dataset:
type: plotly.JSONDataSet # node code
def make_plots() -> Dict[str, go.Figure]:
return {"a": plot_a, "b": plot_b, "c": plot_c} This would produce files |
My situation aligns with what @AntonyMilneQB previously mentioned. Specifically, the primary focus of interest would be centered around the presentation within
And then be saved as mentioned by Antony, I agree with that catalog definition |
This makes a lot of sense to I think. Unfortunately it's not super easy to do and I'm not sure how much demand there is for it, so not sure how high priority it will be. But personally it's something I would like to see added too 👍 |
@antonymilne we're discussing this now in backlog grooming and would love if you could sketch this out:
How do you see that looking in Viz? |
Not sure to be honest... Maybe like a big long list of pictures that makes the metadata panel scrollable? Or little thumbnails which you can then expand in a new modal? Like it is at the moment but the thumbnails would need to be way smaller to fit many more on the page. Or even simpler, just some text that says "multiple plots here, click this button to scroll through them" which thens opens the first one in the modal and you can then browse others by going previous/next on that modal. Or something similar to how we show many plots on the experiment tracking screen. Ultimately there's many ways to do it and I don't have much feeling about which would be best from a balance of UX and engineering effort. One important requirement is that the solution works for any number of plots though (the number is known in advance), not just a couple. |
From my perspective as a user, the option multiple plots here, click this button to scroll through them sounds like a more reasonable way, in the sense of not cluttering up the UI :) |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
Description
I recently asked in the Slack channel whether it would be valuable to enable this feature. Specifically, I would like to be able to save multiple
plotly.JSONDataSet
objects as values from a dictionary and display them as multiple outputs usingkedro-viz
.Context
The context for this request is that I have a node where the number of plots is not fixed, and I would like to have an automated solution to save multiple plots, regardless of the quantity.
Possible Alternatives
As a possible alternative, I suggest adding a button or dynamic parameter in
kedro-viz
to allow users to select the desired plot, to avoid interference with the visual space in case of many graphics.The text was updated successfully, but these errors were encountered: