From 4e58abf15b804afb2a80aa4d9058683a95d4ce36 Mon Sep 17 00:00:00 2001 From: Konrad Sikorski Date: Wed, 7 Dec 2022 23:05:59 +0100 Subject: [PATCH] Kedro CLI startup time made shorter - server.py: Moved `DEFAULT_HOST` and `DEFAULT_PORT` to `constants.py` - launchers/cli.py: Moved `from kedro_viz.server ...` statement to viz function Signed-off-by: Konrad Sikorski --- package/kedro_viz/constants.py | 3 +++ package/kedro_viz/launchers/cli.py | 4 +++- package/kedro_viz/server.py | 3 +-- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/package/kedro_viz/constants.py b/package/kedro_viz/constants.py index 40832da3b8..b225702968 100644 --- a/package/kedro_viz/constants.py +++ b/package/kedro_viz/constants.py @@ -5,3 +5,6 @@ DEFAULT_REGISTERED_PIPELINE_ID = "__default__" KEDRO_VERSION = VersionInfo.parse(kedro.__version__) ROOT_MODULAR_PIPELINE_ID = "__root__" + +DEFAULT_HOST = "127.0.0.1" +DEFAULT_PORT = 4141 diff --git a/package/kedro_viz/launchers/cli.py b/package/kedro_viz/launchers/cli.py index de7594c0f9..ff8fbf8296 100644 --- a/package/kedro_viz/launchers/cli.py +++ b/package/kedro_viz/launchers/cli.py @@ -11,8 +11,8 @@ from watchgod import RegExpWatcher, run_process from kedro_viz import __version__ +from kedro_viz.constants import DEFAULT_HOST, DEFAULT_PORT from kedro_viz.integrations.pypi import get_latest_version, is_running_outdated_version -from kedro_viz.server import DEFAULT_HOST, DEFAULT_PORT, is_localhost, run_server @click.group(name="Kedro-Viz") @@ -81,6 +81,8 @@ def commands(): # pylint: disable=missing-function-docstring callback=_split_params, ) def viz(host, port, browser, load_file, save_file, pipeline, env, autoreload, params): + from kedro_viz.server import is_localhost, run_server + """Visualise a Kedro pipeline using Kedro viz.""" installed_version = VersionInfo.parse(__version__) latest_version = get_latest_version() diff --git a/package/kedro_viz/server.py b/package/kedro_viz/server.py index 4db1651f54..453027d3d6 100644 --- a/package/kedro_viz/server.py +++ b/package/kedro_viz/server.py @@ -11,13 +11,12 @@ from kedro_viz.api import apps from kedro_viz.api.rest.responses import EnhancedORJSONResponse, get_default_response +from kedro_viz.constants import DEFAULT_HOST, DEFAULT_PORT from kedro_viz.data_access import DataAccessManager, data_access_manager from kedro_viz.database import create_db_engine from kedro_viz.integrations.kedro import data_loader as kedro_data_loader from kedro_viz.models.experiment_tracking import Base -DEFAULT_HOST = "127.0.0.1" -DEFAULT_PORT = 4141 DEV_PORT = 4142