Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specifying Kubernetes and OpenShift version #31

Open
kadel opened this issue Jan 16, 2018 · 0 comments
Open

Specifying Kubernetes and OpenShift version #31

kadel opened this issue Jan 16, 2018 · 0 comments

Comments

@kadel
Copy link
Member

kadel commented Jan 16, 2018

Kubernetes version and OpenShift version in entrypoint.sh is defined in a different way.
For Kubernetes for some reason version is saved in k8s-release file. And for OpenShift it is hard coded using commit hash.

K8S_OPENAPI_URL=https://raw.githubusercontent.com/kubernetes/kubernetes/$(curl https://raw.githubusercontent.com/kedgeproject/json-schema-generator/master/scripts/k8s-release)/api/openapi-spec/swagger.json

OS_OPENAPI_URL=https://raw.githubusercontent.com/openshift/origin/1252cce6daeca1b6cc0fd90b1bde5dcdc9a0853b/api/swagger-spec/oapi-v1.json

There should be the common way how versions are defined, so it is easy to change it or test new versions. env variables with default values are a good proven way to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant