-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LA Times puzzles are being downloaded from 2018 #174
Comments
I'm seeing the same thing again unfortunately |
On my Samsung Tab A7, I see puzzles from 2020 (since last couple of months) instead of 2021. I was assuming that this is not an app issue (perhaps issue with site where the files are downloaded from) but since I am seeing 2020 puzzles and others are seeing 2018 puzzles, now I am suspecting the app may be a factor too. |
I looked at LATimesDownLoader.java and did tests and indeed the issue seems to be with the source where files are coming from. The app is downloading the proper filename with year, date, month but the file returned contains 2018, 2020 or 2021 puzzles (depending on the date range). |
Looks like LATimes has moved to a different platform (PuzzleMe by AmuseLabs) and while one can get to Puzzles using https://cdn4.amuselabs.com/lat/crossword?id=tcaYYMMDD&set=latimes&embed=0 (e.g. https://cdn4.amuselabs.com/lat/crossword?id=tca210726&set=latimes&embed=0). The puzzle is returned as HTML/JS code which will likely have to be parsed to get it into data format that can be used by the app. The old website that this app uses (arkadium.com) seems to be recycling old puzzles for now. |
I just opened an issue to add support for AmuseLabs/PuzzleMe, which would fix this issue and enable adding many new crossword services. Hopefully the dev or someone can figure out a simple way to scrape the puzzle pages. Unfortunately not every service uses simple puzzle IDs named with dates, but there is also a standardized selector to access the IDs. |
Thanks for doing the research on this, but I fear that the developer(s) for this app is no longer active. |
Appreciate the comments here - I was having the same issue (reported to the dev in late April by email) and now don't need to do the code research on what's going on. I wonder how cruciverb.com is getting the PUZ files - it still has the recent ones. Might be easier to figure that out than parse the result from AmuseLabs. |
I have found a method to download LATimes puz files and put them in folder where shortyz expects every night. It is not simple, but end result is automated so the crossword just shows up. These steps below are from a combination of following websites https://github.com/thisisparker/xword-dl Step 1: Step 2: Step 3:
The last command will need you to provide Android storage permission and will create folder ~/storage/shared/crosswords will be where your shortyz puzzles will be Now exit termux app (type exit or kill the app using Android UI) and restart termux for crontab to take effect Step 4:
###This should put file where shortyz can find it - Now Launch Shortyz and make sure it sees the new puzzle Step 5: Lines to add to crontab
Step 6: Hope this helps someone - it is a bit complicated to setup but end result justifies the effort for me... |
I have added AmuseLabs support and modified code so LATimes and WaPo use AmuseLabs. I have also submitted a PR (#184). This is a major enough functional fix so that I hope the owner of the repo will be able to spare some time and push a new release to app store. Meanwhile, one can test the changes by downloading a debug APK (at your own risk) from my fork here: https://github.com/jdesai61/shortyz/releases |
@jgok @jbbdude or others |
I just tried it out. It seems to download current LA Times and Atlantic puzzles. I played through today's puzzles and checked them against the Atlantic and LA Times sites. They seem to be working right. I'm testing with an Android 10 device; I normally play on a Kindle running Fire OS 7.3.2.2/Android 9 and I'd be happy to test on that moving forward/as this new build/fork matures. WaPo downloaded the Sunday puzzle for Sunday, and it seems correct based on their web version, but I don't see any of their daily puzzles. I assume adding those puzzles as a separate/new feed (and others I highlighted in my related issue which should probably get merged with this one, and any other PuzzleMe/Amuse Labs puzzles) would be a fairly simple process of swapping in their ID. Not sure whether it would be worthy of its own issue as it's a whole different set of functionality though related, but this app would get way more flexible by adding an "add a source" option which could take as input an RSS feed of .puz files or a PuzzleMe/Amuse Labs link or ID. |
Thanks. In the code, WaPo was only enabled for Sunday downloads, so I left it that way. But I will look further. Kindle test will be very useful. If you do have issues and are able to use adb to connect and get debug logs, that will help as I have left in a few log statements in.
The app supports loading PUZ files emailed thru a gmail account, that may be a workaround instead of RSS feed. Getting people to add links has the potential to become a support nightmare. |
Actually, I did note one minor bug: Emoji support. Not new, as prior emoji in clues have appeared broken. However, in case it's related to the scraping, The Atlantic's 6 across clue today is "❤️" which appears as tofus/.notdefs, i.e. "⛝⛝" (two white boxes with Xs through them). |
@jbbdude I have created a new release https://github.com/jdesai61/shortyz/tree/v4.4.4-debug-beta-rel2 with support for old android devices and also to handle unicode - which will show Feb 27 Atlantic Clue for heart as one white box instead of two (due to utf-8 character set limitation) Direct download link: |
Thank you @jdesai61 - I was hoping someone would post a new build of Shortyz. Does this include all the 3rd-party pull requests? |
I don't have write access to this repo. The debug build is in my fork and only contains my fixes. I don't have ability to create production builds or send app to app stores.
|
I have created a new debug release at https://github.com/jdesai61/shortyz/releases/tag/v4.4.4-debug-beta-rel3 |
The AmuseLabs support is broken again as of June 19th 2022. They changed the obfuscation scheme and I don't have the time to incorporate the fix. For those interested, you can use xword-dl project to get AmuseLabs based puzzles and manually copy them to your shortyz folders. I have documented using termux and xword-dl to achieve this in earlier post in this thread, |
#173
This issue started recurring again, starting with the week of April 26, 2021.
The LA Times puzzle for April 25, 2021 was downloaded currently, but since then I have been seeing puzzles from 2018 being downloaded.
The text was updated successfully, but these errors were encountered: