Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: failed to upload codecov #556

Merged
merged 1 commit into from
Aug 21, 2024
Merged

fix: failed to upload codecov #556

merged 1 commit into from
Aug 21, 2024

Conversation

ty-dc
Copy link
Collaborator

@ty-dc ty-dc commented Aug 8, 2024 •
edited
Loading

最近 kdoctor unittest CI 总是报错, 尝试使用最新的版本。

error - 2024-08-07 20:12:26,794 -- Upload failed: {"detail":"Request was throttled."}
Error: Codecov: 
                      Failed to properly upload report: The process '/home/runner/work/_actions/codecov/codecov-action/v4.0.1/dist/codecov' failed with exit code 1

其次 golanglint 升级了版本，检查更为严格，一些不规范写法被检查出来导致 CI 报错。

Error: pkg/pluginManager/apphttphealthy/agentExecuteTask.go:85:20: printf: non-constant format string in call to fmt.Errorf (govet)
make: *** [Makefile:266: lint_golang_format] Error 1
		err = fmt.Errorf(msg)
		                 ^
Error: pkg/pluginManager/apphttphealthy/agentExecuteTask.go:116:21: printf: non-constant format string in call to fmt.Errorf (govet)
			err = fmt.Errorf(msg)
			                 ^
Error: pkg/pluginManager/apphttphealthy/agentExecuteTask.go:[13](https://github.com/kdoctor-io/kdoctor/actions/runs/10482806487/job/29034513534?pr=556#step:6:14)2:22: printf: non-constant format string in call to fmt.Errorf (govet)
				err = fmt.Errorf(msg)
				                 ^
Error: Process completed with exit code 2.

@ty-dc ty-dc requested a review from weizhoublue as a code owner August 8, 2024 06:46
@codecov Codecov
Copy link

codecov bot commented Aug 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.83%. Comparing base (21d8e1a) to head (4362999).
Report is 2 commits behind head on main.

Files Patch % Lines
pkg/reportManager/worker.go 0.00% 3 Missing ⚠️
pkg/fileManager/manager.go 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #556      +/-   ##
==========================================
- Coverage   81.38%   80.83%   -0.56%     
==========================================
  Files          22       22              
  Lines        1252     1252              
==========================================
- Hits         1019     1012       -7     
- Misses        153      158       +5     
- Partials       80       82       +2
Flag Coverage Δ
unittests 80.83% <0.00%> (-0.56%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
pkg/loadRequest/loadDns/dns.go 91.66% <ø> (ø)
pkg/fileManager/manager.go 59.52% <0.00%> (ø)
pkg/reportManager/worker.go 52.68% <0.00%> (ø)

... and 2 files with indirect coverage changes

@ty-dc ty-dc force-pushed the fix/update-unittest branch 6 times, most recently from b0bf523 to cacc9f7 Compare August 21, 2024 06:14
@ty-dc ty-dc force-pushed the fix/update-unittest branch from cacc9f7 to 4362999 Compare August 21, 2024 06:42
@weizhoublue weizhoublue merged commit 2dcb2d4 into kdoctor-io:main Aug 21, 2024
21 of 22 checks passed
This was referenced Aug 23, 2024
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weizhoublue weizhoublue weizhoublue approved these changes

Assignees
No one assigned
Labels
release/none
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ty-dc @weizhoublue