-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split constants and vocabulary (model) into two distinct files #315
base: master
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for s-forms-kbss ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Good point that it is breaking change, although not for SPipes applications but SPipesComponents. Thus we need to do it little later after we publish new version of SForms. Then we publish next version that will contain this change. Moreover, we need to discuss conventions.E.g. we have: Other issues:
BTW, you can use https://prefix.cc/ to search for meaningful prefixes of URIs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requires more discussion on standup, see my comments.
@LaChope I changed last comment to address "Other issues". Note that after changing |
I am not sure I understand fully in the end. For instance, these should be refactored like so?
|
yes |
Resolves #279.
IMPORTANT NOTE: After this is merged, all applications using s-forms will break and will need to be refactored according to this PR.