Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Odd degassing path behaviour for some models #175

Open
simonwmatthews opened this issue Nov 24, 2022 · 0 comments
Open

Odd degassing path behaviour for some models #175

simonwmatthews opened this issue Nov 24, 2022 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@simonwmatthews
Copy link
Collaborator

There seems to be a small numerical error when calculating degassing paths using (at least) Dixon and IaconoMarziano, whereby the H2O content increases very slightly during decompression. The effect is ~0.0002 wt%, so not noticeable most of the time, apart from when plotting a vertical degassing path.

An inelegant fix would be to detect an increase in H2O and then set it to the original value. A better fix would be figure out why there's such a 'big' numerical error appearing.

Will reflect on this and do something to fix it.

@simonwmatthews simonwmatthews added the bug Something isn't working label Nov 24, 2022
@simonwmatthews simonwmatthews self-assigned this Nov 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant