Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong uncertainty on V-band extinction #105

Open
mdecleir opened this issue Mar 2, 2022 · 0 comments
Open

Wrong uncertainty on V-band extinction #105

mdecleir opened this issue Mar 2, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@mdecleir
Copy link
Collaborator

mdecleir commented Mar 2, 2022

When calculating the band extinctions, there should be a special consideration for the V-band.
E(V-V) will be exactly zero, however, the uncertainties on the V-band extinction are calculated as 2 times the square of the uncertainty on the V-band magnitude. I believe the uncertainty should be 0 instead.

red_mag = red.data["BAND"].get_band_mag(pband_name)
comp_mag = comp.data["BAND"].get_band_mag(pband_name)
if (red_mag is not None) & (comp_mag is not None):
ext = (red_mag[0] - red_rel_band[0]) - (comp_mag[0] - comp_rel_band[0])
unc = np.sqrt(
red_mag[1] ** 2
+ red_rel_band[1] ** 2
+ comp_mag[1] ** 2
+ comp_rel_band[1] ** 2
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants