Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different album and artist cover sources #91

Open
JaxzKyd opened this issue Mar 1, 2023 · 4 comments
Open

Different album and artist cover sources #91

JaxzKyd opened this issue Mar 1, 2023 · 4 comments
Assignees
Labels
feature New feature or request

Comments

@JaxzKyd
Copy link

JaxzKyd commented Mar 1, 2023

Currently if it doesn't find a cover.jpg file for an artist or album, it searches Deezer for them. However, in the case of this set of logs

It's easy to see the issue, so I'm suggesting adding different sources for this? Like Spotify for artist images and maybe album images(I know the Spotify API allows for grabbing artist images, I'm not sure about album covers though)
And assuming you can't get album covers from the Spotify API, maybe try Last.fm?

Also another thing, album covers can be embedded into the music files themselves, maybe also support for those?

Just a few ideas :P

@kaangiray26 kaangiray26 added the feature New feature or request label Mar 2, 2023
kaangiray26 added a commit that referenced this issue Mar 5, 2023
kaangiray26 added a commit that referenced this issue Mar 5, 2023
@kaangiray26
Copy link
Owner

I've replaced Deezer API for album cover search with Last.fm API.

@kaangiray26 kaangiray26 self-assigned this Mar 5, 2023
@JaxzKyd
Copy link
Author

JaxzKyd commented Mar 8, 2023

🤐 (3.0 btw)
image

@JaxzKyd
Copy link
Author

JaxzKyd commented Mar 8, 2023

(also Artists tab, btw nice tabs I like them very much)
image

@kaangiray26
Copy link
Owner

kaangiray26 commented Mar 8, 2023

Album and artist cover search occurs when you restart the app. So, to fill out missing covers, you need to stop and restart the docker-compose.

I hope it works for you this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants