-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Album Artist Link No Longer Working #848
Comments
Thanks for the detailed description. From the attached pictures, it seems something is wrong. However, I just tried this also with Squeezer version 2.3.8 and LMS 9.0.0 (but probably not the latest build), and here it works as expected. This makes me think the issue is server related. If you are not able to pinpoint the issue from this, you can try to enable CometD logs and check the request and response for the Artist query from the Squeezer Now Playing screen. This is enabled via the LMS web-interface, please select Settings/Advanced/Logging and raise the “(network.cometd) - Cometd protocol logging” log-level to Debug. You may paste or attach the logs here, then I can have a look. |
I enabled the CometD debug logging then repeated what is shown in the images I attached earlier then zipped the entire log. You may be right in this being a server issue. There was another Squeezer bug reported on here a couple of months back that I independently posted on the LMS forum and they found that it was a problem with LMS. But there is at least one other person that I am aware of that is having this same issue with LMS 9.0.0 and Squeezer. |
Thanks for the log. I found this request and response for image 3: Request
Response
It may be difficult to read, but it shows there's 1 item in the response
This request is constructed from the response for the context menu (as shown in image 2): The “go” action for the “Artist: Kyuss” entry
It looks correct to me (as far as Squeezer shows what is sends from LMS). For comparison, we can look at the request/response used for the fourth image, if you like. |
This time I just enabled CometD logging then in Squeezer I was already in the Album Artist list view, so I just scrolled down to Kyuss and clicked on it and all 7 albums along with the "Browse on Spotify" showed up. |
OK, so the below request gives the correct result, including the albums from the local library. I notice it is not the same artist ID (even if it's the same artist name). Request
On the first image, I see the album playing is Welcome to SkyValley. Is that started via the list from the fourth image? If not, then try to play the album from the fourth image, and then select the artist from the context menu of the Now Playing screen, and check if this is correct. |
Yes. So I first start Squeezer with nothing playing. I click on "My Music", then "Album Artist" and a list of all artists is shown. I scroll down to "Kyuss" and click on that. I then see a list of all of their albums on my server along with the "Browse on Spotify" below the album list (similar to image 4, but no song is playing). I click on the vertical ellipsis to the right of "Welcome to Sky Valley" and select "Play". Then at the bottom the current song playing is shown, I click on that which results in image 1. I click on the vertical ellipsis to the right (indicated in image 1) and then image 2 is shown. I then click on "Artist: Kyuss" as indicated in image 2. When I do that, I expect to see image 4, but instead I see image 3 which is mostly blank. If at that point I then go back to Home -> My Music -> Album Artist -> Kyuss, I get image 4, which is the list of Kyuss albums on my local server with the track that is currently playing at the bottom. Is it possible that the artist ID being different in the two cases is causing this problem? In the LMS server web interface when I hover the mouse over the artist Kyuss, the link shown includes the artist ID 9810, which is what is shown in the case when the correct results are returned. But if I am looking at the correct thing the artist ID is 5862 in the case where image 3 is shown. I opened the library.db file in a viewer and there is no 5862 artist ID. The lowest number is 7912 and goes up to 11859 By the way, this is happening with all artists, not just Kyuss, I'm just using this one for testing. |
Hmm ... what you describe is actually what I wanted you to try. But I see you already did that. I just tried the same, and here it works as expected. Yes, I think the different artist IDs is causing the problem. Why it happens, though, I don't know. I suggest you submit an issue for this in the LMS forum, or the LMS GitHub page. You can use the request/response examples here, or refer to this issue. |
I wasn't sure if this was an LMS or a Squeezer issue so thanks for verifying that it is an LMS issue. I will submit this to the LMS developers. |
While viewing the current track (in the local library) that is playing if the user clicks on the vertical ellipsis on the right (first image attached), a screen pops up giving options and links.
If you click on "Album" the user is shown all of the tracks on that album, if you click on "Genre", the user is taken to all artists in that Genre, similarly for "Year". But if you click on "Artist" (second attached image), the user is taken to a blank screen (third image) even though the local library contains 7 albums by that artist (fourth image). In previous versions this worked as it should. The Spotty plugin is active in LMS so the Browse on Spotify option is shown. And if the user clicks on that, the albums for that artists in Spotify are displayed.
Squeezer version: 2.3.8
LMS Version: 9.0.0 (Running on Win 10 x64)
Thank you for all of the work for a wonderful app.
The text was updated successfully, but these errors were encountered: