Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor results table #17

Open
jzahedieh opened this issue Aug 17, 2014 · 0 comments
Open

Refactor results table #17

jzahedieh opened this issue Aug 17, 2014 · 0 comments

Comments

@jzahedieh
Copy link
Owner

Messy, inefficient and downright confusing. this is such core functionality it needs to be easier to understand. Part of the problem I am facing is that I cannot think of an efficient way of achieving of what needs to be done, the process will be documented on this issue to hopefully clarify it and improve it.

Diagram of current process

issue-19-table-old-process

Process breakdown

Black: Loops leagues and opponents which are basically the same, a list of Player objects. So for each Player it loops through all their possible opponents to find their results.

Orange: The league players Results are loaded, then all the results are looped to see if they match the current opponent (which is being looped), the result is then filled.

tl;dr loop hell :(

Current process breakdown

todo

New process breakdown

todo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant