Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peerDependencies are defined incorrectly #96

Open
wojtekmaj opened this issue Jan 23, 2024 · 0 comments
Open

peerDependencies are defined incorrectly #96

wojtekmaj opened this issue Jan 23, 2024 · 0 comments

Comments

@wojtekmaj
Copy link

peerDependencies are set to:

react: ">= 16.8.0 || 18.0.0"
react-dom: ">= 16.8.0 || 18.0.0"

>= 16.8.0 matches 16.8.0, 16.9.0, …, 16.50.0, 17.0.0, …, 18.0.0 (!), …, 19.0.0 and so on. This makes >= 16.8.0 || 18.0.0 expression pointless.

I believe your intention was to set the range of supported React versions to ^16.8.0 || ^17.0.0 || ^18.0.0, translating to human speech: Anything above and including 16.8.0, but not 19.0.0 or higher (yet).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant