Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SageMaker endpoint chat settings panel has region name that overlaps placeholder text #365

Closed
JasonWeill opened this issue Aug 28, 2023 · 1 comment
Labels
bug Something isn't working @jupyter-ai/chatui project:config Configuration mechanisms

Comments

@JasonWeill
Copy link
Collaborator

Description

In the chat settings panel, when "SageMaker endpoint :: *" is selected as the language model, the default region name appears with "Region name (required)" superimposed on it.

image

Reproduce

  1. Go to the Jupyter AI settings panel
  2. Select "SageMaker endpoint :: *" as the language model
  3. See the region name text box with both placeholder and text visible.

Expected behavior

As is the case when I click on the text box, the placeholder should appear at the top of the text box.

image

Context

  • Operating System and version: macOS 13.5.1 "Ventura"
  • Browser and version: Firefox 115.1.0esr
  • JupyterLab version: 4.0.3, Jupyter AI tip-of-main
@JasonWeill JasonWeill added bug Something isn't working @jupyter-ai/chatui project:config Configuration mechanisms labels Aug 28, 2023
@JasonWeill JasonWeill added this to the 2.3.0 Release milestone Aug 28, 2023
@JasonWeill JasonWeill removed this from the 2.3.0 Release milestone Jan 25, 2024
@dlqqq
Copy link
Member

dlqqq commented Feb 4, 2025

This doesn't appear to be an issue any more. I believe we fixed this in a separate PR but forgot to mention this issue.

I'll close this for now, and we can open a new issue if this problem persists. 👋

@dlqqq dlqqq closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working @jupyter-ai/chatui project:config Configuration mechanisms
Projects
None yet
Development

No branches or pull requests

2 participants