Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v3-dev] Remove v2 code after reaching feature parity #1146

Closed
dlqqq opened this issue Dec 9, 2024 · 1 comment
Closed

[v3-dev] Remove v2 code after reaching feature parity #1146

dlqqq opened this issue Dec 9, 2024 · 1 comment
Assignees
@brichet
Labels
enhancement New feature or request

Comments

@dlqqq
Copy link
Member

dlqqq commented Dec 9, 2024

Problem

The v2 code for the frontend & server extension needs to be removed once v3 achieves feature parity with v2.

Proposed Solution

  • Remove v2 frontend & server extension code.
  • Make AiExtension.get_chat() return YChat instead of Optional[YChat].

Additional context

@brichet has assigned himself to this issue, per #1043.
@dlqqq dlqqq added the enhancement New feature or request label Dec 9, 2024
@brichet brichet mentioned this issue Dec 18, 2024
Merged
@dlqqq
Copy link
Member Author

dlqqq commented Feb 4, 2025

Closed by #1156.

@dlqqq dlqqq closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brichet brichet

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brichet @dlqqq