From 2f377e3a2ae01feaa1edf6330cb25f432d843617 Mon Sep 17 00:00:00 2001 From: "anujkumar.singh" Date: Wed, 22 Jan 2025 18:34:54 +0530 Subject: [PATCH] fixes - Jupyter AI's broken settings theme --- packages/jupyter-ai/src/index.ts | 1 + .../src/widgets/settings-widget.tsx | 22 +++++++++++-------- 2 files changed, 14 insertions(+), 9 deletions(-) diff --git a/packages/jupyter-ai/src/index.ts b/packages/jupyter-ai/src/index.ts index 14528b51b..bddb74594 100644 --- a/packages/jupyter-ai/src/index.ts +++ b/packages/jupyter-ai/src/index.ts @@ -55,6 +55,7 @@ const plugin: JupyterFrontEndPlugin = { let settingsWidget: ReactWidget; try { settingsWidget = buildAiSettings( + themeManager, rmRegistry, completionProvider, openInlineCompleterSettings diff --git a/packages/jupyter-ai/src/widgets/settings-widget.tsx b/packages/jupyter-ai/src/widgets/settings-widget.tsx index 75436f3c5..ceee12e0e 100644 --- a/packages/jupyter-ai/src/widgets/settings-widget.tsx +++ b/packages/jupyter-ai/src/widgets/settings-widget.tsx @@ -1,26 +1,30 @@ import React from 'react'; -import { ReactWidget } from '@jupyterlab/apputils'; +import { IThemeManager, ReactWidget } from '@jupyterlab/apputils'; import { settingsIcon } from '@jupyterlab/ui-components'; +import { IRenderMimeRegistry } from '@jupyterlab/rendermime'; import { IJaiCompletionProvider } from '../tokens'; -import { IRenderMimeRegistry } from '@jupyterlab/rendermime'; import { ChatSettings } from '../components/chat-settings'; +import { JlThemeProvider } from '../components/jl-theme-provider'; export function buildAiSettings( + themeManager: IThemeManager | null, rmRegistry: IRenderMimeRegistry, completionProvider: IJaiCompletionProvider | null, openInlineCompleterSettings: () => void ): ReactWidget { const SettingsWidget = ReactWidget.create( - + + + ); SettingsWidget.id = 'jupyter-ai::settings'; SettingsWidget.title.icon = settingsIcon; SettingsWidget.title.caption = 'Jupyter AI Settings'; // TODO: i18n return SettingsWidget; -} +} \ No newline at end of file