Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When container fails to start, there is no trace in the jupyterhub logs of the k8s events #397

Open
mrow4a opened this issue Mar 4, 2020 · 1 comment

Comments

@mrow4a
Copy link

mrow4a commented Mar 4, 2020

Currently, we are continuously sending events (https://github.com/jupyterhub/kubespawner/blob/master/kubespawner/spawner.py#L1637), and when spawn is successful, we log them cumulatively in https://github.com/jupyterhub/kubespawner/blob/master/kubespawner/spawner.py#L1843-L1852. However, there is no trace of them in the timeout scenario.

Would it be worth to also log the events to the logs continuously, or at least in crash scenario log them as in success scenario? We could contribute with implementation if something is agreed.

@mrow4a mrow4a changed the title When container fails to start, there is no trace in the jupyterhub logs When container fails to start, there is no trace in the jupyterhub logs of the k8s events Mar 4, 2020
@consideRatio
Copy link
Member

@mrow4a I'm issue triaging and struggle a bit to follow this issue, can you help clarify it?

  1. Can you update the links so they don't point to the right lines, and use a permalink so they don't get outdated.
  2. Can you clarify whenever you mean a k8s Event and a JupyterHub Spawner progress event?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants