Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test coverage of kubespawner #313

Open
choldgraf opened this issue Apr 4, 2019 · 2 comments
Open

Improve test coverage of kubespawner #313

choldgraf opened this issue Apr 4, 2019 · 2 comments

Comments

@choldgraf
Copy link
Member

Given that Kubespawner is a core component of many Jupyter Infra tools (mybinder.org, jupyterhub, binderhub), it'd be great if we could improve the test coverage a bit.

As of creating this issue, we're at 69%, which is a good start! Here's a badge that'll get updated as more tests improve coverage.

codecov

If any folks would like to make improvements to tests, it would be greatly appreciated!

@betatim
Copy link
Member

betatim commented Apr 4, 2019

One thing that worked well (even if it required a lot of hard work!) for repo2docker was to use the following codecov check settings:

comment: off
coverage:
  status:
    project:
      default:
        target: auto
    patch:
      default:
         target: 20% 

It prevents the bot from polluting PR discussions with comments and it nudges you to not merge PRs that decrease coverage. It also asks for at least 20% of the lines you changed to be covered.

I think the nudge of "at least don't reduce coverage" has the net result that coverage increases over time. Without being too much of a "you have to eat your vegetables" kind of annoyance.

@consideRatio
Copy link
Member

consideRatio commented Oct 25, 2020

The coverage is ~80% now if we exclude proxy.py that holds the KubeIngressProxy Python class which is separate from KubeSpawner.

Should we have this issue open as an encouragement for additional tests still? What do you think @choldgraf and @betatim?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants