Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stop_timeout instead of re-using start_timeout #253

Open
elgalu opened this issue Aug 22, 2018 · 2 comments
Open

Add stop_timeout instead of re-using start_timeout #253

elgalu opened this issue Aug 22, 2018 · 2 comments

Comments

@elgalu
Copy link

elgalu commented Aug 22, 2018

I think it would be better to add stop_timeout instead of re-using start_timeout here:

timeout=self.start_timeout,

@minrk
Copy link
Member

minrk commented Sep 3, 2018

Makes sense

@consideRatio
Copy link
Member

consideRatio commented Oct 25, 2020

Still relevant issue.

try:
await exponential_backoff(
lambda: self.pod_reflector.pods.get(self.pod_name, None) is None,
'pod/%s did not disappear in %s seconds!' % (self.pod_name, self.start_timeout),
timeout=self.start_timeout,
)
except TimeoutError:
self.log.error("Pod %s did not disappear, restarting pod reflector", self.pod_name)
self._start_watching_pods(replace=True)
raise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants