Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KubeSpawner vision statement: passthrough to pod spec as much as possible #248

Open
minrk opened this issue Aug 18, 2018 · 1 comment
Open

Comments

@minrk
Copy link
Member

minrk commented Aug 18, 2018

Following #239, I think we should try to stop adding traitlets to KubeSpawner that are simple mappings to entries in the pod spec, and instead work on making passthrough config to Kubernetes a nice experience. As much as possible, I think our goal should be to expose Kubernetes as-is, rather than providing a wrapper around it with different ways to specify all of Kubernetes' existing options, and reserve traitlets for things that need KubeSpawner-level logic (like extra objects, etc.)

That is, things like affinity, etc. should be settable via extra_pod_config and we should provide a nice mechanism for deep-merging merging multiple entries for extra_pod_config, rather than promoting every option to individual traitlets. When met with a proposal to add a new traitlet for a pod attribute, we should try to require that there be a problem setting it with extra_pod_config first, before adding the traitlet.

@tdudgeon
Copy link

It's not just the pod spec that needs to be considered here. It would also be useful to pass things through to the PVC definition. For instance I wanted to be able to specify data for pvc.spec.selector.matchLabels to be able to specify which of a set of pre-existing PVs could be used, but it seems that's not currently possible.

@consideRatio consideRatio changed the title passthrough to pod spec as much as possible KubeSpawner vision statement: passthrough to pod spec as much as possible Oct 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants