From ef2ac83d7fe8b006f53ec6e0c0eb7b23fdc8b44e Mon Sep 17 00:00:00 2001 From: Thijs Walcarius Date: Wed, 25 Jan 2023 13:14:05 +0100 Subject: [PATCH 1/2] Validate JUPYTERHUB_SERVICE_URL port number Fixes https://github.com/jupyter/docker-stacks/issues/1862 --- nbviewer/app.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/nbviewer/app.py b/nbviewer/app.py index c883d9b7..7e980e59 100644 --- a/nbviewer/app.py +++ b/nbviewer/app.py @@ -458,6 +458,11 @@ def default_endpoint(self): if "JUPYTERHUB_SERVICE_URL" in os.environ: url = urlparse(os.environ["JUPYTERHUB_SERVICE_URL"]) default_host, default_port = url.hostname, url.port + + if default_port < 1 or default_port > 65535: + self.log.error("Received invalid port number %d through JUPYTERHUB_SERVICE_URL. " + "Defaulting to 5000 instead.") + default_port = 5000 else: default_host, default_port = "0.0.0.0", 5000 return {"host": default_host, "port": default_port} From 1f2dd3294b16874d1c1dd6a6f8bae5716cf06764 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Thu, 26 Jan 2023 13:20:50 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- nbviewer/app.py | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/nbviewer/app.py b/nbviewer/app.py index 7e980e59..5e8b05a4 100644 --- a/nbviewer/app.py +++ b/nbviewer/app.py @@ -460,8 +460,10 @@ def default_endpoint(self): default_host, default_port = url.hostname, url.port if default_port < 1 or default_port > 65535: - self.log.error("Received invalid port number %d through JUPYTERHUB_SERVICE_URL. " - "Defaulting to 5000 instead.") + self.log.error( + "Received invalid port number %d through JUPYTERHUB_SERVICE_URL. " + "Defaulting to 5000 instead." + ) default_port = 5000 else: default_host, default_port = "0.0.0.0", 5000