Skip to content
This repository has been archived by the owner on Jan 6, 2020. It is now read-only.

[Laravel] Download static datas in public folder or somewhere else... #67

Open
elreco opened this issue Oct 16, 2019 · 1 comment
Open
Assignees
Labels
type:enhancement This issue is a new feature or request

Comments

@elreco
Copy link
Contributor

elreco commented Oct 16, 2019

Hello :)

What do you think about downloading the json files to the public folder for Laravel ?

'champion' => '/public/data/{locale}/champion.json',
'item' => '/public/data/{locale}/item.json',
'championFull' => '/public/data/{locale}/championFull.json',
'runes' => '/public/data/{locale}/runesReforged.json',
'summoner' => '/public/data/{locale}/summoner.json',
'icon' => '/public/data/{locale}/profileicon.json',
'map' => '/public/data/{locale}/map.json',
'language' => '/public/data/{locale}/language.json',

I don't know if it's possible to specify that path only for Laravel environments.

What do you think about it ?

Thank you 👍

@junlarsen junlarsen added the type:enhancement This issue is a new feature or request label Oct 16, 2019
@junlarsen
Copy link
Owner

I'm not exactly sure if we're able to detect whether we're running a Laravel env or not, but what I could do is make an option on the Client to change said directory. If this is a wanted feature I'll look into it.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type:enhancement This issue is a new feature or request
Projects
None yet
Development

No branches or pull requests

2 participants