Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To Do list #1

Open
14 of 21 tasks
julia-wrobel opened this issue Sep 29, 2022 · 1 comment
Open
14 of 21 tasks

To Do list #1

julia-wrobel opened this issue Sep 29, 2022 · 1 comment

Comments

@julia-wrobel
Copy link
Owner

julia-wrobel commented Sep 29, 2022

  • Edit sim_gfpca function to simulate Poisson, binary, or Gaussian data
  • unhard code K = 4 FPCs
  • return correct scores
  • check correct scaling of eigenfunctions, and make sure to be consistent for overlap vs. no overlap
  • index using seq(0, 1)
  • add in code to get eigenfunctions rather than using approx()
  • documentation for main functions
  • vignette
  • check compatibility with refund.shiny
  • currently breaks for some values of binwidth- play around with this
  • Allow more general input (like a matrix) for Y
  • Use variable names that reflect Andrew's notation in the paper
  • add progress bar for overlap = FALSE
  • add unit tests
  • build in errors/ messages for poor input from the user
  • Make sure code still works when input Y is not ordered by subject-domain
  • remove unnecessary tidyverse functions (pipe, etc)
  • clean up binning code for overlap= TRUE option and be consistent with code used by Andrew in paper.
  • make sure user-specified arguments can be passed to fpca.face, bam, and glmer
  • Add predict() function
  • Add plot() function
  • [ ]
@julia-wrobel
Copy link
Owner Author

julia-wrobel commented Oct 4, 2022

For unit tests specifically, do

  • checks that simulation function works for all three families
  • check that fpca works for all three families- what behavior do we want for family = "gaussian"? Probably to tell people to use fpca. face and just return that.
  • check that multiple user inputs for binwidth work
  • check that both npc and pve are valid arguments for gfpca function
  • check case 1 and case 2, overlap and no overlap
  • check periodicity works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant