Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't load stuff that is in the current workspace #87

Open
davidanthoff opened this issue Feb 3, 2020 · 1 comment
Open

Don't load stuff that is in the current workspace #87

davidanthoff opened this issue Feb 3, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@davidanthoff
Copy link
Member

I believe right now we are loading everything that is in the Julia environment that we pass to the SymServer. So if we have an env and the current working folder in VS Code is deved into that env, then SymServer will load the content of the package that we are currently editing.

It seems to me that in general we don't want to load anything that is somewhere in the folder hierarchy under any of the root folders of the workspace at all, after all the content of those files will be obtained from parsing etc., right? I.e. the philosophy should be that SymServer only loads stuff that is outside of the workspace that is currently edited in VS Code.

@ZacLN, does that sound right to you?

@davidanthoff davidanthoff added the enhancement New feature or request label Feb 3, 2020
@davidanthoff davidanthoff added this to the Next milestone Feb 3, 2020
@ZacLN
Copy link
Contributor

ZacLN commented Feb 3, 2020

Broadly -yes, this fits in with the solution being discussed on the LOAD_PATH issue. One caveat - the inability of StaticLint to pick up hard to find bindings (e.g. macro gen'ed or eval'ed stuff) will become more obvious in some cases.

@davidanthoff davidanthoff modified the milestones: Next Minor, Backlog Aug 17, 2020
@davidanthoff davidanthoff removed this from the Backlog milestone Oct 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants