Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support mixed encodings in MTF files #6

Closed
juk0de opened this issue Jul 18, 2024 · 0 comments · Fixed by #7
Closed

Support mixed encodings in MTF files #6

juk0de opened this issue Jul 18, 2024 · 0 comments · Fixed by #7
Assignees
@juk0de
Labels
enhancement New feature or request
Milestone
Convert all Biped...

Comments

@juk0de
Copy link
Owner

juk0de commented Jul 18, 2024 •
edited
Loading

For unknown reasons, MTF files are encoded in different formats. Most are pure ASCII, but some contain UTF-8 characters, while others contain CP-1252 (also known as Windows-1252) characters. Currently, this causes exceptions when trying to read a file with the wrong format.

Examples:

  • "Atlas AS7-K" : contains UTF-8 characters
  • "Zeus X ZEU-X": contains CP-1252 characters
@juk0de juk0de added the enhancement New feature or request label Jul 18, 2024
@juk0de juk0de self-assigned this Jul 18, 2024
@juk0de juk0de added this to the Convert all Biped Mechs milestone Jul 18, 2024
juk0de added a commit that referenced this issue Jul 18, 2024
@juk0de
test_specific_biped: added testcase for 'Dragon_Fire_DGR-3FR', which …
310304a 
…contains CP-1252 encoded chars (#6)
juk0de added a commit that referenced this issue Jul 18, 2024
@juk0de
mtf2json: added decoder for mixed encodings in MTF files (#6)
f862c8e
juk0de added a commit that referenced this issue Jul 18, 2024
@juk0de
test_cli: replaced 'read_text()' and 'write_text()' to avoid encoding…
d21248a 
… errors (#6)
@juk0de juk0de changed the title Support different encodings for MTF files Support mixed encodings in MTF files Jul 18, 2024
@juk0de juk0de mentioned this issue Jul 18, 2024
Merged
@juk0de juk0de closed this as completed in #7 Jul 19, 2024
@juk0de juk0de closed this as completed in 75918ed Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@juk0de juk0de

Labels
enhancement New feature or request
Projects
None yet
Milestone
Convert all Biped Mechs
Development

Successfully merging a pull request may close this issue.

Mixed encodings support (v0.1.5) juk0de/mtf2json
1 participant
@juk0de