-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Patchwork armor may raise exceptions #4
Comments
juk0de
pushed a commit
that referenced
this issue
Jul 15, 2024
juk0de
pushed a commit
that referenced
this issue
Jul 15, 2024
juk0de
pushed a commit
that referenced
this issue
Jul 15, 2024
juk0de
pushed a commit
that referenced
this issue
Jul 15, 2024
juk0de
pushed a commit
that referenced
this issue
Jul 15, 2024
juk0de
pushed a commit
that referenced
this issue
Jul 15, 2024
juk0de
pushed a commit
that referenced
this issue
Jul 17, 2024
juk0de
pushed a commit
that referenced
this issue
Jul 17, 2024
juk0de
pushed a commit
that referenced
this issue
Jul 17, 2024
juk0de
pushed a commit
that referenced
this issue
Jul 17, 2024
juk0de
pushed a commit
that referenced
this issue
Jul 17, 2024
juk0de
pushed a commit
that referenced
this issue
Jul 17, 2024
juk0de
pushed a commit
that referenced
this issue
Jul 17, 2024
juk0de
pushed a commit
that referenced
this issue
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
Patchwork armor currently raises an exception because the entries may contain "subkeys" (nested keys) that describe the armor type for each location, e. g.:
Note that not all locations have a type subkey. In that case it's probably (hopefully?) safe to assume that it means "Standard(IS/Clan)".
Example mech:
Zeus X ZEU-X
.Error raised:
ValueError: invalid literal for int() with base 10: 'Reactive(Inner Sphere)'
Possible Solution
Restructure the
armor
section and group by location:In order to keep the JSON layout consistent, the
structure
section should be changed accordingly (i.e. remove thestructure.pips
subsection).This solution breaks compatibility because it modifies the JSON data structure.
The text was updated successfully, but these errors were encountered: