From d1c15a677275e44c3fed8c287159743794e88f6a Mon Sep 17 00:00:00 2001 From: judovana Date: Mon, 3 Feb 2025 20:31:16 +0100 Subject: [PATCH] warn on false negatives if repro_compare.sh is run after comparable_patch.sh in ReproducibleBuilds.md (#4123) * warn on false negatives if repro_compare.sh is run after comparable_patch.sh in ReproducibleBuilds.md * Removed trailing space --- tooling/reproducible/ReproducibleBuilds.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tooling/reproducible/ReproducibleBuilds.md b/tooling/reproducible/ReproducibleBuilds.md index cf5627e40..495b225e8 100755 --- a/tooling/reproducible/ReproducibleBuilds.md +++ b/tooling/reproducible/ReproducibleBuilds.md @@ -50,6 +50,8 @@ The patching process involves: - Remove any non-deterministic build process artifact strings, like Manifest Created-By stamps. - Zero out CRC in .gnu_debuglink ELF sections to eliminate .debuginfo-induced differences. +**warning:** If you run `comparable_patch.sh`, do not use `repro_compare.sh` for final comparison. You would get false negatives. Run plain `diff jdk1 jdk2` with any switches you need. + ### How to setup and run comparable_patch.sh on Windows #### Tooling setup: