all-the-icons-dired--refresh-advice doesn't check display-graphic-p
#52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A custom variable which points to a function. When this function returns true dired icons will be added to the current buffer.
|
This check is probably not necessary anyway since all-the-icons are backed by an icon font. Either your terminal has the font patched to display these icons or it doesn't. In any case, this check should be done in init.el by the user themselves. |
wyuenho
added a commit
to wyuenho/all-the-icons-dired
that referenced
this pull request
Feb 11, 2021
|
Fair enough. I can get the same affect as this patch by just adding a |
|
That's exactly what I do :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #51