From b60a5c0e9ce14e02ea17835a537256a27e373dfa Mon Sep 17 00:00:00 2001 From: Joel Strait Date: Fri, 30 Dec 2022 12:20:26 -0800 Subject: [PATCH] Modifying example to avoid possible confusion The size of the "fmt " chunk in the example is intentionally being changed to a value other than 40, to avoid inadvertently implying that this bug fix only applies to files in WAVE_FORMAT_EXTENSIBLE format. Together with the final sentence of the previous bug fix, it seems like the old example size could have led to that conclusion. --- CHANGELOG | 4 ++-- README.markdown | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/CHANGELOG b/CHANGELOG index e40e19e..ffb2276 100644 --- a/CHANGELOG +++ b/CHANGELOG @@ -59,8 +59,8 @@ chunk. The message will now correctly state that the chunk extension is too large, rather than `"Not a supported wave file. The format chunk extension is shorter than expected."`. As an example of what "too large" means, if a - `"fmt "` chunk has a size of 40 bytes, then any chunk extension larger than - 22 bytes will be too large and overflow out of the chunk, since a chunk + `"fmt "` chunk has a size of 50 bytes, then any chunk extension larger than + 32 bytes will be too large and overflow out of the chunk, since a chunk extension's content always starts at byte 18 (0-based). diff --git a/README.markdown b/README.markdown index 2b5f1cd..94c84f3 100644 --- a/README.markdown +++ b/README.markdown @@ -98,7 +98,7 @@ The full details: * **Bug Fix:** More accurate message on the `InvalidFormatError` raised when reading a file whose `"fmt "` chunk extension is too large to fit in the chunk. - The message will now correctly state that the chunk extension is too large, rather than `"Not a supported wave file. The format chunk extension is shorter than expected."`. As an example of what "too large" means, if a `"fmt "` chunk has a size of 40 bytes, then any chunk extension larger than 22 bytes will be too large and overflow out of the chunk, since a chunk extension's content always starts at byte 18 (0-based). + The message will now correctly state that the chunk extension is too large, rather than `"Not a supported wave file. The format chunk extension is shorter than expected."`. As an example of what "too large" means, if a `"fmt "` chunk has a size of 50 bytes, then any chunk extension larger than 32 bytes will be too large and overflow out of the chunk, since a chunk extension's content always starts at byte 18 (0-based). # Previous Release: v1.1.1