Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The oauth client id and secret need to be moved #39

Open
jstark518 opened this issue Sep 14, 2022 · 2 comments
Open

The oauth client id and secret need to be moved #39

jstark518 opened this issue Sep 14, 2022 · 2 comments
Labels
Updates scripts

Comments

@jstark518
Copy link
Owner

They should be resolved using webpack/environment variables and compiled in with github secrets for prod.
@jstark518 jstark518 moved this to 🆕 New (Unassigned) in Desktop Deploy Sep 18, 2022
@leosalca
Copy link
Collaborator

leosalca commented Oct 2, 2022

Are they not already env variables?

@jstark518
Copy link
Owner Author

They're in that .env.json file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Updates scripts
Projects
Desktop Deploy
Status: 🆕 New (Unassigned)
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jstark518 @leosalca