Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow endDate to be omitted or set to "present" #410

Closed
joebobmiles opened this issue Feb 12, 2021 · 10 comments
Closed

Allow endDate to be omitted or set to "present" #410

joebobmiles opened this issue Feb 12, 2021 · 10 comments

Comments

@joebobmiles
Copy link

Piggy backing off of this comment on the v1.0 road map. Seems a bit silly that this was overlooked, but the first thing that goes into work history is usually your current job. Naturally, this does not have an end date, so it is incorrect to provide one.

I would recommend either allowing users to omit the endDate (either with the empty string "", undefined, or null) or provide the keyword "present". My preference would be to only allow "present" or undefined.

@nkhil
Copy link

nkhil commented Feb 22, 2021

Agreed. I'd love for this to added. I'm willing to contribute to this - would I be making a pull request into this repository: https://github.com/jsonresume/resume-schema ?

Thanks 😄

@nkhil
Copy link

nkhil commented Feb 23, 2021

I've got a draft PR set up here to do this: #411

This only allows present as string literal, and does not allow for undefined as a value. This change (in its current format) will also change the from property to be set to present which isn't right. I'm just making this as a draft PR for opinions/interest in it.

@jamesliudotcc
Copy link

I think this is really a documentation problem. It is possible to omit endDate, and the meaning is clear enough. It would be up to the generators to correctly handle a missing end date.

@SethFalco
Copy link
Member

SethFalco commented Aug 6, 2021

All properties are already optional as it is. In JSON Schema, it's the required property that dictates if a property is required or not. It's never used at all in JSON Resume currently.

More info: https://json-schema.org/understanding-json-schema/reference/object.html#required-properties

Unfortunately, the problem mostly lies with theme implementations that don't handle cases where endDate is undefined. As @jamesliudotcc pointed out, the documentation could be improved to encourage theme developers to treat fields as such.

I won't take any action now, but in my opinion null/undefined should be treated as present. I don't think we need a dedicated present value. (Some themes already do this.)

@thomasdavis
Copy link
Member

@SethFalco said it correct. Most current themes just look for the omission of the property (which is allowed), closing this thread for now.

@SethFalco
Copy link
Member

SethFalco commented May 15, 2023

I actually kept this open as I was thinking we could make a page on the website for recommendations when interpreting the JSON file. (… time really flies. ^-^')

i.e.:

  • For address, never assume all address fields are there, make an array and join the specified fields with a comma. (For example, I only write UK, but some themes render ,,,UK,.)
  • If endDate isn't present, assume it's an ongoing position.
  • Optional but for backward compatibility, consider falling back to the old property names (from pre 1.0.0 release.)

I'll make a separate ticket on the website for this though and think about what else to put.

@SethFalco
Copy link
Member

SethFalco commented May 15, 2023

@thomasdavis Ahh, actually, I see you archived the repo for the website. What's the plan for maintaining/hosting jsonresume.org then?

@thomasdavis
Copy link
Member

I've got it setup with https://turbo.build/ hosted on Vercel. The homepage and registry. I will invite you to colab now so you can check it out but not ready to put in the org just yet. In the next couple days, will clean it up, remove secrets I committed and flatten the commits. Just added some silly AI endpoints for fun -> https://jsonresume.org/getting-started/

@thomasdavis thomasdavis reopened this May 15, 2023
@SethFalco
Copy link
Member

Closing this as I'm tracking the documentation task on my own.
Will get a formal write-up going, and we'll figure out if the advice is agreeable and where to put it.

@oschrenk
Copy link

Would be great to add this.

Using the recommended browser extension https://github.com/joshuatz/linkedin-to-jsonresume will create endDate = "", and since that extension is a very good entry to bootstrap your resume.json I think it's prudent to soften up the schema, or at least add an FAQ point to the website.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants