-
Notifications
You must be signed in to change notification settings - Fork 282
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow endDate to be omitted or set to "present" #410
Comments
Agreed. I'd love for this to added. I'm willing to contribute to this - would I be making a pull request into this repository: https://github.com/jsonresume/resume-schema ? Thanks 😄 |
I've got a draft PR set up here to do this: #411 This only allows |
I think this is really a documentation problem. It is possible to omit |
All properties are already optional as it is. In JSON Schema, it's the More info: https://json-schema.org/understanding-json-schema/reference/object.html#required-properties Unfortunately, the problem mostly lies with theme implementations that don't handle cases where I won't take any action now, but in my opinion |
@SethFalco said it correct. Most current themes just look for the omission of the property (which is allowed), closing this thread for now. |
I actually kept this open as I was thinking we could make a page on the website for recommendations when interpreting the JSON file. (… time really flies. ^-^') i.e.:
I'll make a separate ticket on the website for this though and think about what else to put. |
@thomasdavis Ahh, actually, I see you archived the repo for the website. What's the plan for maintaining/hosting jsonresume.org then? |
I've got it setup with https://turbo.build/ hosted on Vercel. The homepage and registry. I will invite you to colab now so you can check it out but not ready to put in the org just yet. In the next couple days, will clean it up, remove secrets I committed and flatten the commits. Just added some silly AI endpoints for fun -> https://jsonresume.org/getting-started/ |
Closing this as I'm tracking the documentation task on my own. |
Would be great to add this. Using the recommended browser extension https://github.com/joshuatz/linkedin-to-jsonresume will create |
Piggy backing off of this comment on the v1.0 road map. Seems a bit silly that this was overlooked, but the first thing that goes into work history is usually your current job. Naturally, this does not have an end date, so it is incorrect to provide one.
I would recommend either allowing users to omit the endDate (either with the empty string
""
,undefined
, ornull
) or provide the keyword "present". My preference would be to only allow"present"
orundefined
.The text was updated successfully, but these errors were encountered: