Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming Issues #4

Open
joshgachnang opened this issue Nov 25, 2013 · 0 comments
Open

Naming Issues #4

joshgachnang opened this issue Nov 25, 2013 · 0 comments

Comments

@joshgachnang
Copy link
Owner

There are some naming issues. pyaddress is missing street post direction. e.g. 12006 120th Pl NE, Kirkland, WA
ambiguous naming: apartment should be unit_designator or simply designator.
designators include apartment, unit, suite, department, etc.
unit numbers should go into a designator_number. eg unit 38 should not lose it's designation
More than anything here needs to be consistency in the naming.
we should refer to USPS Publication 28: http://pe.usps.com/text/pub28/welcome.htm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant