Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

execjs support #2

Open
ryanstout opened this issue May 24, 2015 · 6 comments
Open

execjs support #2

ryanstout opened this issue May 24, 2015 · 6 comments

Comments

@ryanstout
Copy link

So after doing a bunch of research, clean-css is great. I'm currently using this gem in voltframework - https://github.com/voltrb/volt ) My users on windows are having trouble installing libv8, and it would be great if the windows users could use a different JS runtime. I'm not sure if there's libv8 specific features your using, but if your interested in adding execjs support, let me know and maybe I or someone else from the volt community could help.

Thanks!

@ryanstout
Copy link
Author

Ok, upon further inspection, looks like you have to stub out a good chunk of the node api to get it to work, which it doesn't look like is possible with execjs.

@ai
Copy link

ai commented Nov 14, 2016

Any updates? We need it in our project too.

@joseph Say if you need any specific help.

@joseph
Copy link
Owner

joseph commented Nov 14, 2016

Hi, this isn't an active project, and I don't know anything about Windows, but feel free to fork away.

@ai
Copy link

ai commented Nov 14, 2016

@joseph we need only remove libv8 and use execjs. It uses best JS engine on current machine. Fix will be very small. Here is how I do it in Autoprefixer Rails https://github.com/ai/autoprefixer-rails/blob/master/lib/autoprefixer-rails/processor.rb#L107-L112

@joseph
Copy link
Owner

joseph commented Nov 14, 2016

Perhaps. At the time, I tried quite hard to use ExecJS rather than libv8. I don't recall the specific obstacles, but Ryan's point above sounds familiar. If you can make it work, I'm happy to look at a pull request.

@ai
Copy link

ai commented Nov 14, 2016

@gazay as Ruby developer of our project. do you want to help :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants