Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IE check #256

Open
ludis opened this issue Jan 9, 2015 · 1 comment
Open

IE check #256

ludis opened this issue Jan 9, 2015 · 1 comment

Comments

@ludis
Copy link

ludis commented Jan 9, 2015

This check for IE in monocle.js 3.2.0, in Monocle.Browser.is:
IE: !!(window.attachEvent && !Monocle.Browser.uaMatch('Opera')),

// above check fails on IE11
// http://stackoverflow.com/a/20411654
IE: (navigator.userAgent.indexOf('MSIE') !== -1 || navigator.appVersion.indexOf('Trident/') > 0),

Seems to work fine.
@jbhoot
Copy link

jbhoot commented Mar 27, 2015

I second this change. Monocle seems to incorrectly identify IE 11 engine as Gecko.

Monocle.Browser.engine === 'Gecko'

With the suggested change above, Monocle correctly identifies IE11, which fixes an issue I am facing - due to incorrect identification, horizontal and vertical scrollbars appear in the reader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbhoot @ludis