Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement scenario when is the same album but different artist using LastFM #104

Open
josdem opened this issue Feb 16, 2025 · 2 comments
Open

Comments

@josdem
Copy link
Owner

josdem commented Feb 16, 2025

As user I want to implement missing scenario: when we have the same album in all metadata collection but different artist so that I can do a better request to LastFM

Acceptance Criteria

  • I have a method in CompleteService to figure out if we have the same album but different artist in the metadata collection
  • I have another method in LastFMAlbumHelper when I search only by album name
  • From the given album collection, try to get the best match based on release date.
  • All tests passing
@ionesosa-e
Copy link
Contributor

Hi!
I’m interested in contributing to this issue and I believe I can help implement it. Could you assign it to me?

Looking forward to your confirmation!

@josdem
Copy link
Owner Author

josdem commented Feb 18, 2025

Hi! I’m interested in contributing to this issue and I believe I can help implement it. Could you assign it to me?

Looking forward to your confirmation!

Hi @ionesosa-e I appreciate you want to contribute with this issue; however, it is still in analysis, I hope you can find something interesting to work in ready issues within this coming release: https://github.com/josdem/jmetadata/milestone/4 if not, I will let you know when this issue is ready to pick it up.

@josdem josdem moved this to Todo in jmetadata-roadmap Feb 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Todo
Development

No branches or pull requests

2 participants