Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

annoying background colour of fisher output #435

Closed
znculee opened this issue Jul 14, 2018 · 5 comments
Closed

annoying background colour of fisher output #435

znculee opened this issue Jul 14, 2018 · 5 comments
Labels
bug Something isn't working outdated Forgotten lore

Comments

@znculee
Copy link

znculee commented Jul 14, 2018

When I install a new plugin or run (fisher up), there is an output like the following figure.
image
Obviously, there's a background colour in some of the output text. I can temporally check it with selection, as the following figure.
image
However, this is really annoying. Could you cancel this background colour? I'll appreciate that.
I also tried to revised the fisher.fish, but I haven't made it done.

@FabioAntunes
Copy link
Contributor

Wow, I was just looking into this and trying to find a solution. There was a ticket related to this that was closed. #378

I also found these related issues:
mochajs/mocha#802
altercation/solarized#240
altercation/solarized#220 (comment)
altercation/solarized#164

One of the possible solutions is increasing the contrast by one third on your iTerm2 but that is far from great

@FabioAntunes
Copy link
Contributor

FabioAntunes commented Jul 14, 2018

I have tested a couple of themes all of them 256 colors, there are some that are better than others but on the overall I would say there isn't a perfect one:

solarized-dark
solarized-256

materia
materia-256

solarflare
solarflare-256

flat
flat-256

oceanicnext
oceanicnext-256

nord
nord-256

All of these themes are from base16

@znculee
Copy link
Author

znculee commented Jul 14, 2018

@FabioAntunes Great survey! I think it would be better if there is just no background colour.

@jorgebucaran
Copy link
Owner

jorgebucaran commented Sep 6, 2018

I agree this is quite annoying. What's odd is that I don't recall having added a background color to this output. Incredible.

@jorgebucaran
Copy link
Owner

jorgebucaran commented Oct 5, 2018

@znculee @FabioAntunes The CLI output has been redesigned in fisher/releases/tag/3.0.0, removing all colorized text and special characters.

Here is an example of what you get now:

$ fisher
fetching https://codeload.github.com/fisherman/getopts/tar.gz/master
fetching https://codeload.github.com/fisherman/spin/tar.gz/master
linking ~/.config/fish/functions/getopts.fish
linking ~/.config/fish/completions/spin.fish
linking ~/.config/fish/functions/spin.fish
linking ~/.config/fish/conf.d/keybinder.fish
fetching https://codeload.github.com/fisherman/getopts/tar.gz/master
linking ~/.config/fish/functions/getopts.fish
added 1 package, updated 3 packages, removed 7 packages in 1.82s

@jorgebucaran jorgebucaran added bug Something isn't working outdated Forgotten lore labels Oct 5, 2018
Repository owner locked as resolved and limited conversation to collaborators Oct 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working outdated Forgotten lore
Projects
None yet
Development

No branches or pull requests

3 participants