From 0fb68a4c6efff8fe1cad428c977422f00bbcdc23 Mon Sep 17 00:00:00 2001 From: jordanmontt Date: Tue, 13 Feb 2024 16:15:19 +0100 Subject: [PATCH] Improved exporting methods --- src/IllimaniProfiler/GCLogger.class.st | 13 +++++-------- src/IllimaniProfiler/IllEphemeron.class.st | 14 +++++++------- .../IllFinalizationProfiler.class.st | 10 ++++++---- 3 files changed, 18 insertions(+), 19 deletions(-) diff --git a/src/IllimaniProfiler/GCLogger.class.st b/src/IllimaniProfiler/GCLogger.class.st index 19596f3..a9fff67 100644 --- a/src/IllimaniProfiler/GCLogger.class.st +++ b/src/IllimaniProfiler/GCLogger.class.st @@ -15,14 +15,11 @@ Class { { #category : 'exporting' } GCLogger >> export: writeStream data: someData header: aHeaderInCollection [ - | writer | - writer := NeoCSVWriter on: writeStream. - - writer writeHeader: #( #fullGCsBySecond ). - fullGCs do: [ :aNumber | - writer nextPut: aNumber ]. - - writer close + (NeoCSVWriter on: writeStream) + writeHeader: #( #fullGCsBySecond ); + fieldWriter: #raw; + nextPut: someData; + close ] { #category : 'exporting' } diff --git a/src/IllimaniProfiler/IllEphemeron.class.st b/src/IllimaniProfiler/IllEphemeron.class.st index 5a2aa04..961707d 100644 --- a/src/IllimaniProfiler/IllEphemeron.class.st +++ b/src/IllimaniProfiler/IllEphemeron.class.st @@ -44,13 +44,13 @@ IllEphemeron >> finalizationTime: anObject [ IllEphemeron >> flatInstanceVariables [ ^ { - finalizationTime asString. - sizeInBytes asString. - initializationTime asString. - allocatedObjectClass asString. - survivedScavenges asString. - survivedFullGC asString. - forcedFinalization asString } + finalizationTime. + sizeInBytes. + initializationTime. + allocatedObjectClass. + survivedScavenges. + survivedFullGC. + forcedFinalization } ] { #category : 'finalization' } diff --git a/src/IllimaniProfiler/IllFinalizationProfiler.class.st b/src/IllimaniProfiler/IllFinalizationProfiler.class.st index d111a44..52c8208 100644 --- a/src/IllimaniProfiler/IllFinalizationProfiler.class.st +++ b/src/IllimaniProfiler/IllFinalizationProfiler.class.st @@ -27,9 +27,11 @@ IllFinalizationProfiler >> exportEphemerons: fileName [ | writeStream writer | writeStream := fileName asFileReference createFile writeStream. - writer := NeoCSVWriter on: writeStream. - - writer writeHeader: ephemeronsCollection first headerToExportCSV. + writer := (NeoCSVWriter on: writeStream) + writeHeader: ephemeronsCollection first headerToExportCSV; + fieldWriter: #raw; + yourself. + ephemeronsCollection do: [ :anIllEphemeron | writer nextPut: anIllEphemeron flatInstanceVariables ]. @@ -99,8 +101,8 @@ IllFinalizationProfiler >> objectAllocations [ { #category : 'profiling' } IllFinalizationProfiler >> startProfiling [ + gcLogger := GCLogger new run. super startProfiling. - gcLogger := GCLogger new run ] { #category : 'accessing - statistics' }