Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Force login #71

Merged
merged 2 commits into from
Mar 6, 2022
Merged

Force login #71

merged 2 commits into from
Mar 6, 2022

Conversation

jonodrew
Copy link
Owner

@jonodrew jonodrew commented Mar 5, 2022

Two changes here:

  1. Force login. I've put in a little login page. (We'll need to set variables in Heroku before we deploy this!). Users can't access any other page before they've logged in. I've also updated the cookies page to reflect this new cookie
  2. Delete the Google OAuth flow, as we're not using it

jonathankerr added 2 commits March 5, 2022 09:31
Remove Google auth flow
66b156d 
Since we're not using this any more, let's get rid of it. We can always add it back in later
Force login
a4c48fc 
We've not yet got an encrypted connection, so users shouldn't be using this with production data. This will enable us to show off the software to stakeholders without risking real data
@jonodrew
Copy link
Owner Author

jonodrew commented Mar 5, 2022

This should close #52 for the moment

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

✅ Result of Pytest Coverage

---------- coverage: platform linux, python 3.9.10-final-0 -----------

Name Stmts Miss Cover
app/init.py 16 0 100%
app/auth/init.py 3 0 100%
app/auth/routes.py 17 2 88%
app/config.py 10 1 90%
app/extensions.py 3 0 100%
app/helpers.py 10 1 90%
app/main/init.py 7 1 86%
app/main/routes.py 104 29 72%
app/tasks/init.py 10 2 80%
app/tasks/tasks.py 17 5 71%
TOTAL 197 41 79%
================= 19 passed, 6

@jonodrew jonodrew linked an issue Mar 5, 2022 that may be closed by this pull request
Proposal: domain name #52
Closed
@jonodrew
Copy link
Owner Author

jonodrew commented Mar 5, 2022

@johnpeart - can you pull this and have a click around? The username and password when you run it locally are described in the docker-compose.override.yml file. I'll share the real ones via another channel, once we deploy

@johnpeart
Copy link
Collaborator

@jonodrew seems to work to me!

@jonodrew jonodrew merged commit fb17c8b into main Mar 6, 2022
@jonodrew jonodrew deleted the force-login branch March 6, 2022 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proposal: domain name
2 participants
@jonodrew @johnpeart