Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of beep character #5360

Open
2 tasks done
Torinde opened this issue Jan 1, 2025 · 0 comments
Open
2 tasks done

Handling of beep character #5360

Torinde opened this issue Jan 1, 2025 · 0 comments
Labels

Comments

@Torinde
Copy link
Contributor

Torinde commented Jan 1, 2025

Describe the bug

When pasting hex character 07 from host clipboard DOSbox-X crashes without a message.

Steps to reproduce the behaviour

On host - copy character
Paste in DOSbox via the menu

Expected behavior

To be accepted for processing (e.g. beep/show/etc.) in the same way as Alt+Numpad7

What operating system(s) this bug have occurred on?

Windows 10

What version(s) of DOSBox-X have this bug?

2024.10.1

Used configuration

No response

Output log

No response

Additional information

Observations:

X

type - beep, shows space in its place
at prompt - paste from clipboard as single symbol - crash without message
at prompt - paste from clipboard in the middle of string - skipped
at prompt - Alt+Numpad7 - beep, shows space in its place
echo from prompt - muffled/short beep, shows no space in its place
echo from file - muffled/short beep, shows no space in its place
dir at volume label that has it - muffled/short beep, shows no space in its place

Staging

type - beep, shows no space in its place
at prompt - Alt+Numpad7 - beep, shows no space in its place, beeps also on each subsequent character entered
at prompt - paste from clipboard - string cut at its place (so nothing gets pasted if it's the only symbol)
echo from prompt - beep, shows no space in its place
echo from file - no beep, shows no space in its place
dir at volume label that has it - beep, shows no space in its place

86Box PC DOS 7.00

at prompt - Alt+Numpad7 - no beep, shows ^G
echo from prompt - short beep, shows no space in its place
echo from file - short beep, shows no space in its place
type - short beep, shows no space in its place
dir at volume label that has it - short beep, shows no space in its place

Not tested:
dir of filename/directory that has that symbol
hardware PC

What I think should be improved:

  • Paste from host clipboard to do the same as as Alt+Numpad7
    • do not crash at paste from clipboard as single symbol
    • do not skip at paste from clipboard in the middle of string
  • To beep in the same way in all cases
    • echo/dir of volume label to have the same beep as type/prompt - not the current muffled/short one

Have you checked that no similar bug report(s) exist?

  • I have searched and didn't find any similar bug report.

Code of Conduct & Contributing Guidelines

  • I agree to follow the code of conduct and the contributing guidelines.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant