Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A better way to present genes? #19

Closed
Dx-wmc opened this issue Nov 14, 2024 · 4 comments · Fixed by #20
Closed

A better way to present genes? #19

Dx-wmc opened this issue Nov 14, 2024 · 4 comments · Fixed by #20
Labels
enhancement New feature or request

Comments

@Dx-wmc
Copy link

Dx-wmc commented Nov 14, 2024

Hi, I am delighted to be using this software. I have a small suggestion. Currently, the gene display is limited to a square shape, which can feel a bit monotonous and doesn’t indicate gene direction. Would it be possible to add an option to choose different shapes, such as arrows, to show gene orientation? Additionally, it would be wonderful if genes on the positive and negative strands could be selectively displayed on two separate rows to improve readability like #17.

@jonas-fuchs
Copy link
Owner

Hi, glad you like it. :) I'll have a look. Arrows should not be a problem I think, but in this case it would not be necessary to display them on two rows.

@jonas-fuchs jonas-fuchs added the enhancement New feature or request label Nov 14, 2024
@jonas-fuchs jonas-fuchs linked a pull request Nov 14, 2024 that will close this issue
@jonas-fuchs
Copy link
Owner

jonas-fuchs commented Nov 14, 2024

Could you do a test drive if that works in your hands (see PR) before I close this issue?

You can do this by:

git clone https://github.com/jonas-fuchs/virHEAT
git checkout gene_vis
pip install .
virheat <your_args> --gene-arrows

Arrows are actually quite hard to control, so it might not always look good. I played around a bit and I think I found a decent solution ;).

Here its with my testdata:
virheat example_data/ test -g example_data/SARS-CoV-2.gff3 -r NC_045512 --gene-arrows
virHEAT_plot.pdf

@Dx-wmc
Copy link
Author

Dx-wmc commented Nov 14, 2024

Hi, I followed your method to install and test. For testing the direction of the gene, I manually modified the gff file. Overall, the result looks very good!
virHEAT_plot-1.pdf

@jonas-fuchs
Copy link
Owner

Then I will likely merge th pr soon :) Cheers

@Dx-wmc Dx-wmc closed this as completed Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants