Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak usage when there is only one input VCF #14

Closed
MarieLataretu opened this issue Jun 4, 2024 · 1 comment · Fixed by #15
Closed

Tweak usage when there is only one input VCF #14

MarieLataretu opened this issue Jun 4, 2024 · 1 comment · Fixed by #15
Labels
enhancement New feature or request

Comments

@MarieLataretu
Copy link

Hi @jonas-fuchs, thanks for this tool :)

I tested virHEAT on one sample with the default parameters and run into the error, that there is nothing to plot:

virheat vcf out -l $LEN # only one file in the vcf folder
Frequency array seems to be empty. There is nothing to plot.

At first, I thought that my VCF file has an incompatible format. But actually, delete_common_mutations removes all mutations and delete is true by default:

virHEAT/virheat/command.py

Lines 160 to 161 in 07e59b3

if args.delete:
frequency_array = data_prep.delete_common_mutations(frequency_array, unique_mutations)

It perfectly works with one sample and --no-delete!

I think it would be nice to warn the user (and suggest using --no-delete) or skip delete_common_mutations (even if delete is true), if there is only one input VCF.

@jonas-fuchs
Copy link
Owner

Thanks for the feedback! I will do this in the next update. Might switch the default just to 'no-delete' or ignore it if just one sample is used 👍👍👍

@jonas-fuchs jonas-fuchs added the enhancement New feature or request label Jun 4, 2024
@jonas-fuchs jonas-fuchs linked a pull request Aug 6, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants