bugfix(demo):fix demo build webpack config #293 #294
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for demo build - i was unable to run locally
Demo loaded html page with no javascript, it was broken for a few different reasons.
I made 3 changes to fix this.
cross-env
added so Windows users can run also (cross-env link)./node-modules/webpack/.bin/webpack
is OS incompatible so i added a webpack script:webpack serve --config ./examples/webpack.config.js --mode development
this ensures webpack runs correctly for whatever environment its being run in as opposed to
./node-modules/webpack/.bin/webpack
which won't.Now
npm run demo
ornpm run start
works and displays/runs the demo, and doesn't show a html page with no javascript anymoreAll tests pass.
Fixes #293